From d116649be7920bc04d27f0096f00f6247e6b293b Mon Sep 17 00:00:00 2001 From: Lindsay Mathieson Date: Thu, 25 Apr 2013 11:53:27 +1000 Subject: Changes order of link actions for link context menu Moved "Open Here" action (if needed) to after "Open in Private Window" so as to keep the order of link actions consistent. This reduces the need for users to inspect the context menu when right clicking links. REVIEW: 110168 --- src/webtab/webview.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'src') diff --git a/src/webtab/webview.cpp b/src/webtab/webview.cpp index 44b24cc5..df91451f 100644 --- a/src/webtab/webview.cpp +++ b/src/webtab/webview.cpp @@ -380,14 +380,6 @@ void WebView::contextMenuEvent(QContextMenuEvent *event) sendByMailAction->setText(i18n("Share link")); - if (m_isExternalLinkHovered) - { - a = new KAction(KIcon("view-close"), i18n("Open &Here"), this); - a->setData(m_contextMenuHitResult.linkUrl()); - connect(a, SIGNAL(triggered(bool)), this, SLOT(openLinkHere())); - menu.addAction(a); - } - a = new KAction(KIcon("tab-new"), i18n("Open in New &Tab"), &menu); a->setData(m_contextMenuHitResult.linkUrl()); connect(a, SIGNAL(triggered(bool)), this, SLOT(openLinkInNewTab())); @@ -406,6 +398,14 @@ void WebView::contextMenuEvent(QContextMenuEvent *event) menu.addAction(a); } + if (m_isExternalLinkHovered) + { + a = new KAction(KIcon("view-close"), i18n("Open &Here"), this); + a->setData(m_contextMenuHitResult.linkUrl()); + connect(a, SIGNAL(triggered(bool)), this, SLOT(openLinkHere())); + menu.addAction(a); + } + menu.addSeparator(); // Don't show dots if we are NOT going to ask for download path -- cgit v1.2.1