From de68f1570747203bc7ff9bfb1c17ee1580928e5d Mon Sep 17 00:00:00 2001
From: Andrea Diamantini <adjam7@gmail.com>
Date: Tue, 4 May 2010 17:30:40 +0200
Subject: reply deleteLater.. This time seems good.

---
 src/webpage.cpp | 11 ++++++-----
 src/webpage.h   |  2 +-
 2 files changed, 7 insertions(+), 6 deletions(-)

(limited to 'src')

diff --git a/src/webpage.cpp b/src/webpage.cpp
index b510311e..99a1a6d2 100644
--- a/src/webpage.cpp
+++ b/src/webpage.cpp
@@ -236,7 +236,7 @@ void WebPage::handleUnsupportedContent(QNetworkReply *reply)
     // NOTE
     // This is probably needed just in ONE stupid case..
     if (_protHandler.postHandling(reply->request(), mainFrame()))
-        return;
+        return reply->deleteLater();
 
     if (reply->error() == QNetworkReply::NoError)
     {
@@ -255,7 +255,7 @@ void WebPage::handleUnsupportedContent(QNetworkReply *reply)
             ? KMessageBox::sorry(view(), i18n("No service can handle this :("))
             : downloadRequest(reply->request());
 
-            return;
+            return reply->deleteLater();
         }
 
         if (!isLocal)
@@ -267,10 +267,10 @@ void WebPage::handleUnsupportedContent(QNetworkReply *reply)
             case KParts::BrowserOpenOrSaveQuestion::Save:
                 kDebug() << "service handling: download!";
                 downloadRequest(reply->request());
-                return;
+                return reply->deleteLater();
 
             case KParts::BrowserOpenOrSaveQuestion::Cancel:
-                return;
+                return reply->deleteLater();
 
             default: // non extant case
                 break;
@@ -306,7 +306,7 @@ void WebPage::handleUnsupportedContent(QNetworkReply *reply)
             KRun::run(*appService, url, 0);
         }
 
-        return;
+        return; // FIXME: crash reply->deleteLater();
     }
 }
 
@@ -386,6 +386,7 @@ void WebPage::manageNetworkErrors(QNetworkReply *reply)
         break;
 
     }
+    reply->deleteLater();
 }
 
 
diff --git a/src/webpage.h b/src/webpage.h
index 41c14295..c729a883 100644
--- a/src/webpage.h
+++ b/src/webpage.h
@@ -79,7 +79,7 @@ private slots:
     void updateImage(bool ok);
 
 private:
-    QString errorPage(QNetworkReply *);
+    QString errorPage(QNetworkReply *reply);
     QUrl _loadingUrl;
 
     ProtocolHandler _protHandler;
-- 
cgit v1.2.1