From 07cb3631b381a8ba3fcba44e3d20a40d19b83e39 Mon Sep 17 00:00:00 2001 From: Aqua-sama Date: Sat, 22 Dec 2018 20:34:08 +0100 Subject: Dropping bookmarks onto a folder now inserts it at the first position BUG: #8 Dragging bookmarks onto folders crash --- lib/bookmarks/model/bookmarkitem.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'lib/bookmarks') diff --git a/lib/bookmarks/model/bookmarkitem.cpp b/lib/bookmarks/model/bookmarkitem.cpp index 4715b6f..21d034f 100644 --- a/lib/bookmarks/model/bookmarkitem.cpp +++ b/lib/bookmarks/model/bookmarkitem.cpp @@ -51,8 +51,11 @@ bool BookmarkItem::appendChild(BookmarkItem *childItem) bool BookmarkItem::insertChild(int position, BookmarkItem *childItem) { + // position is invalid (-1) when dropping an item onto the folder, which leads to crash + // make sure that position passed is >= 0 (insert item at first position) + if(m_type == Folder || m_type == Root) { - m_children.insert(position, childItem); + m_children.insert(qMax(position, 0), childItem); return true; } -- cgit v1.2.1