From 9e73d0dac0774955348a5164087363c5b33927b8 Mon Sep 17 00:00:00 2001 From: Aqua-sama Date: Fri, 18 Jan 2019 16:56:54 +0100 Subject: Add tools/report-clang-tidy.sh - Fix various clang-tidy warnings - Fix use-after-free crash when deleting profiles --- lib/urlfilter/hostlist/hostlist.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/urlfilter') diff --git a/lib/urlfilter/hostlist/hostlist.cpp b/lib/urlfilter/hostlist/hostlist.cpp index ec0b214..ff652cf 100644 --- a/lib/urlfilter/hostlist/hostlist.cpp +++ b/lib/urlfilter/hostlist/hostlist.cpp @@ -62,11 +62,11 @@ void HostList::parseLine(const QString& line) return; const QStringList parts = parsedLine.split(QLatin1Literal(" ")); - const QString redirect = parts.at(0); + const QString &redirect = parts.at(0); const auto action = (redirect == QLatin1Literal("0.0.0.0")) ? UrlFilter::Block : UrlFilter::Redirect; for(int i = 1; i < parts.size(); i++) { - const QString domain = parts.at(i); + const QString &domain = parts.at(i); Rule r; r.action = action; r.domainHash = qHash(domain); -- cgit v1.2.1