From 9c4dd932c6d692178bb8d5265c634126cb415767 Mon Sep 17 00:00:00 2001 From: Aqua-sama Date: Tue, 26 May 2020 22:23:25 +0300 Subject: Turn on more warnings by default - fix clazy warnings - fix various other compiler warnings - bugfix: connect profiles' downloadRequested signal --- plugins/ProfileEditor/forms/profileview.cpp | 4 ++-- plugins/ProfileEditor/forms/settingstable.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'plugins') diff --git a/plugins/ProfileEditor/forms/profileview.cpp b/plugins/ProfileEditor/forms/profileview.cpp index 992364c..23713cb 100644 --- a/plugins/ProfileEditor/forms/profileview.cpp +++ b/plugins/ProfileEditor/forms/profileview.cpp @@ -111,8 +111,8 @@ ProfileView::ProfileView(const QString &name, QWebEngineProfile *profile, QSetti connectSetting(ui->printElementBackgrounds, m_profile, QWebEngineSettings::PrintElementBackgrounds); // cookies tab - for(const auto &data : profile->property("cookies").toList()) { - for(const auto &cookie : QNetworkCookie::parseCookies(data.toByteArray())) { + for(auto &raw_cookies : profile->property("cookies").toList()) { + for(auto &cookie : QNetworkCookie::parseCookies(raw_cookies.toByteArray())) { cookieAdded(cookie); } } diff --git a/plugins/ProfileEditor/forms/settingstable.cpp b/plugins/ProfileEditor/forms/settingstable.cpp index 6cfe144..88781a7 100644 --- a/plugins/ProfileEditor/forms/settingstable.cpp +++ b/plugins/ProfileEditor/forms/settingstable.cpp @@ -47,7 +47,7 @@ void SettingsTable::connect(QSettings *settings, const QString §ion) setItem(row, 1, new QTableWidgetItem("value")); }); - QObject::connect(removeBtn, &QToolButton::clicked, [this, settings, section]() { + QObject::connect(removeBtn, &QToolButton::clicked, settings, [this, settings, section]() { settings->beginGroup(section); const int row = currentRow(); @@ -60,7 +60,7 @@ void SettingsTable::connect(QSettings *settings, const QString §ion) settings->endGroup(); }); - QObject::connect(this, &QTableWidget::cellChanged, [this, settings, section](int row, int column) { + QObject::connect(this, &QTableWidget::cellChanged, settings, [this, settings, section](int row, int column) { // no value has been created yet if(item(row, 1) == nullptr) { return; -- cgit v1.2.1