From 9e73d0dac0774955348a5164087363c5b33927b8 Mon Sep 17 00:00:00 2001
From: Aqua-sama <aqua@iserlohn-fortress.net>
Date: Fri, 18 Jan 2019 16:56:54 +0100
Subject: Add tools/report-clang-tidy.sh

- Fix various clang-tidy warnings
- Fix use-after-free crash when deleting profiles
---
 src/browser.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'src/browser.cpp')

diff --git a/src/browser.cpp b/src/browser.cpp
index 6e1e2ba..430a7d4 100644
--- a/src/browser.cpp
+++ b/src/browser.cpp
@@ -216,11 +216,12 @@ void Browser::setup(QVector<QPluginLoader *> plugins)
     // bookmarks
     m_bookmarks = std::make_shared<BookmarksWidget>(QString::fromStdString(m_config->value<std::string>("bookmarks.path").value()));
     connect(m_bookmarks.get(), &BookmarksWidget::showContextMenu, this, [this](const QUrl &url, const QPoint &pos) {
-        auto *menu = new QMenu(m_bookmarks.get());
         auto *subwindow = m_windows.last()->currentSubWindow();
         if(subwindow == nullptr)
             return;
 
+        auto *menu = new QMenu(m_bookmarks.get());
+
         menu->addAction(tr("Open link in current tab"), subwindow, [url, subwindow]() {
             subwindow->currentView()->load(url);
         });
-- 
cgit v1.2.1