From 36adca24ff8ea1daacf5a3c8d09124dc1c78b6fa Mon Sep 17 00:00:00 2001 From: Aqua-sama Date: Sat, 21 Nov 2020 18:26:08 +0200 Subject: Fix test failures Updated sha256sum for bumped rcc version --- src/about/aboutdialog.cpp | 4 +++- src/bookmarks/builtin.cpp | 2 +- src/webengine/meson.build | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/about/aboutdialog.cpp b/src/about/aboutdialog.cpp index 059e3bf..6fa4127 100644 --- a/src/about/aboutdialog.cpp +++ b/src/about/aboutdialog.cpp @@ -27,7 +27,9 @@ AboutDialog::AboutDialog(QWidget *parent) : QDialog(parent) , ui(new Ui::AboutDialog) { - setAttribute(Qt::WA_DeleteOnClose, true); + // This causes a double-free in the destructor + //setAttribute(Qt::WA_DeleteOnClose, true); + ui->setupUi(this); constexpr auto icon_svg = logos::get([] { return std::string_view("poi_window.svg"); }); diff --git a/src/bookmarks/builtin.cpp b/src/bookmarks/builtin.cpp index 732aa64..1ef516b 100644 --- a/src/bookmarks/builtin.cpp +++ b/src/bookmarks/builtin.cpp @@ -103,6 +103,6 @@ int sub_bookmarks(const QStringList &l, Browser &) delete out; delete model; - return EXIT_FAILURE; + return EXIT_SUCCESS; } } // namespace diff --git a/src/webengine/meson.build b/src/webengine/meson.build index 47e4adf..da59006 100644 --- a/src/webengine/meson.build +++ b/src/webengine/meson.build @@ -21,7 +21,7 @@ test('profilemanager', executable('profilemanager', 'test/profilemanager.cpp', d suite: 'webengine') test('view', executable('view', 'test/view.cpp', dependencies: [ dep_qt5, dep_webengine, dep_catch ]), - args: [ '-platform', 'offscreen' ], + #args: [ '-platform', 'offscreen' ], env: { 'PROFILE' : meson.current_source_dir()/'test/testing.profile', 'URL' : meson.current_source_dir()/'test/sample.html' }, suite: 'webengine') -- cgit v1.2.1