diff options
| author | pbos@chromium.org <pbos@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2014-06-04 08:54:07 +0000 |
|---|---|---|
| committer | pbos@chromium.org <pbos@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2014-06-04 08:54:07 +0000 |
| commit | 20583f05605d203fbaf231e6bf1229a58a11a260 (patch) | |
| tree | 83e04354d2fdd3cb6d3c1c8339037f831cbec88f | |
| parent | Add missing MD_MISCINFO_FLAGS1_BUILDSTRING. Revise documentation to clarify (diff) | |
| download | breakpad-20583f05605d203fbaf231e6bf1229a58a11a260.tar.xz | |
Add virtual dtor to LibcurlWrapper.
LibcurlWrapper is deleted but contains no virtual destructor, triggering
warnings with -Wdelete-non-virtual-dtor in clang++.
R=ivanpe@chromium.org
Review URL: https://breakpad.appspot.com/7664002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1337 4c0a9323-5329-0410-9bdc-e9ce6186880e
| -rw-r--r-- | src/common/linux/libcurl_wrapper.cc | 2 | ||||
| -rw-r--r-- | src/common/linux/libcurl_wrapper.h | 1 |
2 files changed, 3 insertions, 0 deletions
diff --git a/src/common/linux/libcurl_wrapper.cc b/src/common/linux/libcurl_wrapper.cc index 08307f02..4ff9bb01 100644 --- a/src/common/linux/libcurl_wrapper.cc +++ b/src/common/linux/libcurl_wrapper.cc @@ -57,6 +57,8 @@ LibcurlWrapper::LibcurlWrapper() return; } +LibcurlWrapper::~LibcurlWrapper() {} + bool LibcurlWrapper::SetProxy(const string& proxy_host, const string& proxy_userpwd) { if (!init_ok_) { diff --git a/src/common/linux/libcurl_wrapper.h b/src/common/linux/libcurl_wrapper.h index 3b72b5e7..3d46c2e6 100644 --- a/src/common/linux/libcurl_wrapper.h +++ b/src/common/linux/libcurl_wrapper.h @@ -40,6 +40,7 @@ namespace google_breakpad { class LibcurlWrapper { public: LibcurlWrapper(); + ~LibcurlWrapper(); virtual bool Init(); virtual bool SetProxy(const string& proxy_host, const string& proxy_userpwd); |