aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Frysinger <vapier@chromium.org>2019-03-31 05:57:52 -0400
committerMike Frysinger <vapier@chromium.org>2019-04-07 14:08:29 +0000
commit4d550cceca107f36c4bc1ea1126b7d32cc50f424 (patch)
tree80f176b69abb71d261613175f55e710727ee7fec
parentmac dump_syms: remove unused vars to fix -Werror build failures (diff)
downloadbreakpad-4d550cceca107f36c4bc1ea1126b7d32cc50f424.tar.xz
linux_core_dumper: partially disable test on Android
Running this test on android-kitkat-arm-rel fails for some reason: [ RUN ] LinuxCoreDumperTest.VerifyExceptionDetails linux_core_dumper_unittest.cc:170: Failure Expected: (0U) != (dumper.crash_address()), actual: 0 vs 0 linux_core_dumper_unittest.cc:178: Failure Expected equality of these values: 2U Which is: 2 info.size() Which is: 0 [ FAILED ] LinuxCoreDumperTest.VerifyExceptionDetails (7 ms) Disable it for now on Android until someone can look into it. Bug: google-breakpad:791 Change-Id: I40a5e3dbeeb44e5eb0df187e61d55e07d8ad3613 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1546778 Reviewed-by: Mark Mentovai <mark@chromium.org>
-rw-r--r--src/client/linux/minidump_writer/linux_core_dumper_unittest.cc9
1 files changed, 9 insertions, 0 deletions
diff --git a/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc b/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc
index 5f27d893..314257d9 100644
--- a/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc
+++ b/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc
@@ -166,6 +166,15 @@ TEST(LinuxCoreDumperTest, VerifyExceptionDetails) {
EXPECT_TRUE(dumper.IsPostMortem());
+#if defined(__ANDROID__)
+ // TODO: For some reason, Android doesn't seem to pass this.
+ if (!dumper.crash_address()) {
+ fprintf(stderr, "LinuxCoreDumperTest.VerifyExceptionDetails test is "
+ "skipped due to missing signal details on Android");
+ return;
+ }
+#endif
+
// Check the exception details.
EXPECT_NE(0U, dumper.crash_address());
EXPECT_EQ(kCrashSignal, dumper.crash_signal());