diff options
| author | Ted Mielczarek <ted@mielczarek.org> | 2015-10-07 14:19:23 -0400 |
|---|---|---|
| committer | Ted Mielczarek <ted@mielczarek.org> | 2015-10-07 14:19:23 -0400 |
| commit | 4ee6f3cd1cd0e42c2146152be67143e7bf0e7a35 (patch) | |
| tree | 90ae171d4ea2577f3e65b62b641c72a93ec160b5 | |
| parent | Support for multiple upload files in CrashReportSender/HTTPUpload (diff) | |
| download | breakpad-4ee6f3cd1cd0e42c2146152be67143e7bf0e7a35.tar.xz | |
Fix Windows crash_generation_server for debug builds without -D_DEBUG
Debug Gecko builds don't build with -D_DEBUG, so the ifdef in
crash_generation_server doesn't work right. The MSDN documentation for
assert says that it's enabled based on the absence of the NDEBUG define,
so using that seems sensible.
R=thestig@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1398453002 .
| -rw-r--r-- | src/client/windows/crash_generation/crash_generation_server.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/client/windows/crash_generation/crash_generation_server.cc b/src/client/windows/crash_generation/crash_generation_server.cc index 2c4f072c..bb0968fe 100644 --- a/src/client/windows/crash_generation/crash_generation_server.cc +++ b/src/client/windows/crash_generation/crash_generation_server.cc @@ -85,7 +85,7 @@ static bool IsClientRequestValid(const ProtocolMessage& msg) { msg.assert_info != NULL); } -#ifdef _DEBUG +#ifndef NDEBUG static bool CheckForIOIncomplete(bool success) { // We should never get an I/O incomplete since we should not execute this // unless the operation has finished and the overlapped event is signaled. If |