aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorivanpe@chromium.org <ivanpe@chromium.org>2015-06-20 00:32:37 +0000
committerivanpe@chromium.org <ivanpe@chromium.org>2015-06-20 00:32:37 +0000
commit893e93a41f10e44e908bc0e3c20fb350affa9c4f (patch)
treef9376df81527ed61c6aa44ca4433c92b6b2525ac
parentUpdate breakpad for Android packed relocations. (diff)
downloadbreakpad-893e93a41f10e44e908bc0e3c20fb350affa9c4f.tar.xz
Use local variable for out parameter rather than direct use of ivar
- Resolves spurious static analyzer warning about response_ being potentially leaked due to the retain in Xcode 6.3 and later. I'm submitting this on behalf of Brian Moore. R=qsr@chromium.org Review URL: https://codereview.chromium.org/1171693007 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1460 4c0a9323-5329-0410-9bdc-e9ce6186880e
-rw-r--r--src/common/mac/HTTPMultipartUpload.m5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/common/mac/HTTPMultipartUpload.m b/src/common/mac/HTTPMultipartUpload.m
index 29fa040b..2ed1b632 100644
--- a/src/common/mac/HTTPMultipartUpload.m
+++ b/src/common/mac/HTTPMultipartUpload.m
@@ -195,10 +195,11 @@
if ([[req URL] isFileURL]) {
[[req HTTPBody] writeToURL:[req URL] options:0 error:error];
} else {
+ NSURLResponse *response = nil;
data = [NSURLConnection sendSynchronousRequest:req
- returningResponse:&response_
+ returningResponse:&response
error:error];
- [response_ retain];
+ response_ = (NSHTTPURLResponse *)[response retain];
}
[req release];