aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLei Zhang <thestig@google.com>2016-01-06 16:16:01 -0800
committerLei Zhang <thestig@google.com>2016-01-06 16:16:01 -0800
commit8c49d62005f2e67c369ad2a8f37e5cbd58ea6592 (patch)
tree01ccc1f2adbf012f38b77dee204d12bf2e549a7e
parentMake minidump-2-core.cc build with -Wformat. (diff)
downloadbreakpad-8c49d62005f2e67c369ad2a8f37e5cbd58ea6592.tar.xz
Avoid comparing size_t to be < 0 on AArch64.
cpu_features_entries is empty on AArch64 and causes tautological-compare warning when compiling with Clang. A=dskiba@google.com Original Review: https://codereview.chromium.org/1562223002/ BUG=chromium:539781 Review URL: https://codereview.chromium.org/1566893002 .
-rw-r--r--src/client/linux/minidump_writer/minidump_writer.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/client/linux/minidump_writer/minidump_writer.cc b/src/client/linux/minidump_writer/minidump_writer.cc
index 4b1e6f87..65e655ac 100644
--- a/src/client/linux/minidump_writer/minidump_writer.cc
+++ b/src/client/linux/minidump_writer/minidump_writer.cc
@@ -1093,8 +1093,8 @@ class MinidumpWriter {
value_len = 0;
}
for (size_t i = 0;
- i < sizeof(cpu_features_entries)/
- sizeof(cpu_features_entries[0]);
+ i != sizeof(cpu_features_entries) /
+ sizeof(cpu_features_entries[0]);
++i) {
const CpuFeaturesEntry* entry = &cpu_features_entries[i];
if (tag_len == strlen(entry->tag) &&