diff options
| author | Robert Sesek <rsesek@chromium.org> | 2017-12-15 11:47:15 -0500 |
|---|---|---|
| committer | Robert Sesek <rsesek@chromium.org> | 2017-12-15 16:50:42 +0000 |
| commit | c283630201acedb25190d3b73ad0416fb55e4639 (patch) | |
| tree | 1f30b12413cdf122fcfd2f69e37f85b5188769ab | |
| parent | Update binaries with dump_syms changes to write new field (diff) | |
| download | breakpad-c283630201acedb25190d3b73ad0416fb55e4639.tar.xz | |
Reconcile -[BreakpadController withBreakpadRef:] with its documentation.
The header states that if the controller is not -start:'ed that it will call
the block with a NULL BreakpadRef. As previously implemented, it asserted if
it was not started.
Change-Id: I3a329a773c0484dc1b74013717b68426758ea2cd
Reviewed-on: https://chromium-review.googlesource.com/829834
Reviewed-by: Mark Mentovai <mark@chromium.org>
| -rw-r--r-- | src/client/ios/BreakpadController.mm | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/client/ios/BreakpadController.mm b/src/client/ios/BreakpadController.mm index 22f397a9..dc5a2d1e 100644 --- a/src/client/ios/BreakpadController.mm +++ b/src/client/ios/BreakpadController.mm @@ -249,10 +249,8 @@ NSString* GetPlatform() { } - (void)withBreakpadRef:(void(^)(BreakpadRef))callback { - NSAssert(started_, - @"The controller must be started before withBreakpadRef is called"); dispatch_async(queue_, ^{ - callback(breakpadRef_); + callback(started_ ? breakpadRef_ : NULL); }); } |