diff options
| author | mseaborn@chromium.org <mseaborn@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-05-10 20:58:49 +0000 |
|---|---|---|
| committer | mseaborn@chromium.org <mseaborn@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-05-10 20:58:49 +0000 |
| commit | e775f8bb16c6d2ebb4c156e7616d9f8ad1991cab (patch) | |
| tree | 6225a128b8a65c49603bae734a6ad0f06c0d5093 | |
| parent | Fix a "set but not used" compiler warning in libdisasm (diff) | |
| download | breakpad-e775f8bb16c6d2ebb4c156e7616d9f8ad1991cab.tar.xz | |
Fix a "set but not used" compiler warning in a test
Add a missing assertion whose absence made the test ineffective.
Make the test a little stricter too.
BUG=none
TEST="make check" to run the test + use "-Wall -Werror"
Review URL: https://breakpad.appspot.com/592003
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1180 4c0a9323-5329-0410-9bdc-e9ce6186880e
| -rw-r--r-- | src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc b/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc index db11651c..04da30b4 100644 --- a/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc +++ b/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc @@ -86,10 +86,11 @@ TEST(LinuxPtraceDumperTest, ThreadList) { bool found = false; for (size_t i = 0; i < dumper.threads().size(); ++i) { if (dumper.threads()[i] == getpid()) { + ASSERT_FALSE(found); found = true; - break; } } + ASSERT_TRUE(found); } // Helper stack class to close a file descriptor and unmap |