diff options
| author | digit@chromium.org <digit@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-09-05 08:08:53 +0000 |
|---|---|---|
| committer | digit@chromium.org <digit@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-09-05 08:08:53 +0000 |
| commit | f792eecd1e1b6325ef9e7cdfcf06e44550a2516a (patch) | |
| tree | fbd0ed1bed6dd9047dfe9bf064d6da79967d13f7 | |
| parent | Properly redeliver (or don't) signals to the previous handlers. (diff) | |
| download | breakpad-f792eecd1e1b6325ef9e7cdfcf06e44550a2516a.tar.xz | |
Fix README.ANDROID + formatting
This patch updates README.ANDROID, since the client library
now supports directly generating a minidump without raising
a signal, and that it builds and runs fine on Android/x86.
+ Formatting fixes in minidump_writer_unittest.cc
Review URL: https://breakpad.appspot.com/446002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1026 4c0a9323-5329-0410-9bdc-e9ce6186880e
| -rw-r--r-- | README.ANDROID | 9 | ||||
| -rw-r--r-- | src/client/linux/minidump_writer/minidump_writer_unittest.cc | 4 |
2 files changed, 4 insertions, 9 deletions
diff --git a/README.ANDROID b/README.ANDROID index dcee4f9f..5814db45 100644 --- a/README.ANDROID +++ b/README.ANDROID @@ -5,13 +5,8 @@ This document explains how to use the Google Breakpad client library on Android, and later generate valid stack traces from the minidumps it generates. -Note that this release only supports ARM-based Android systems. -We're working on adding support for x86 and MIPS, but that might -require an udpated NDK release. - -IMPORTANT: Currently, Minidump generation only works when a signal is - handled by Breakpad. I.e. calling WriteMinidump() directly - at runtime will not work. +This release supports ARM and x86 based Android systems. MIPS is not +currently supported by Breakpad. I. Building the client library: =============================== diff --git a/src/client/linux/minidump_writer/minidump_writer_unittest.cc b/src/client/linux/minidump_writer/minidump_writer_unittest.cc index 7a8d7f17..7558bee4 100644 --- a/src/client/linux/minidump_writer/minidump_writer_unittest.cc +++ b/src/client/linux/minidump_writer/minidump_writer_unittest.cc @@ -329,8 +329,8 @@ TEST(MinidumpWriterTest, DeletedBinary) { // Copy binary to a temp file. AutoTempDir temp_dir; string binpath = temp_dir.path() + "/linux-dumper-unittest-helper"; - ASSERT_EQ(true, CopyFile(helper_path.c_str(), binpath.c_str())) \ - << "Failed to copy " << helper_path << " to " << binpath; + ASSERT_TRUE(CopyFile(helper_path.c_str(), binpath.c_str())) + << "Failed to copy " << helper_path << " to " << binpath; ASSERT_EQ(0, chmod(binpath.c_str(), 0755)); int fds[2]; |