diff options
| author | Andrew Bonventre <andybons@chromium.org> | 2016-07-21 15:50:13 -0400 |
|---|---|---|
| committer | Mark Mentovai <mark@chromium.org> | 2016-07-27 20:07:49 +0000 |
| commit | f7be4815a20a29683949d5e4520f2429372e538b (patch) | |
| tree | cb46e06e3374d0d953910106036f3776a67883ca | |
| parent | Test Gerrit (diff) | |
| download | breakpad-f7be4815a20a29683949d5e4520f2429372e538b.tar.xz | |
Switch to Gerrit for code reviews
BUG=629128
Change-Id: I687659d9fc78ed31dcd3be3b9268f30c17dd9c01
Reviewed-on: https://chromium-review.googlesource.com/362370
Reviewed-by: Mark Mentovai <mark@chromium.org>
| -rw-r--r-- | README.md | 7 | ||||
| -rw-r--r-- | codereview.settings | 7 |
2 files changed, 7 insertions, 7 deletions
@@ -76,6 +76,7 @@ dependent repos are up-to-date. e.g. `git commit ... && git cl upload ...` You will be prompted for credential and a description. -4. At https://codereview.chromium.org/ you’ll find your issue listed; click on - it, and select Publish+Mail, and enter in the code reviewer and CC - google-breakpad-dev@googlegroups.com +4. At https://chromium-review.googlesource.com/ you'll find your issue listed; + click on it, then “Add reviewer”, and enter in the code reviewer. Depending + on your settings, you may not see an email, but the reviewer has been + notified with google-breakpad-dev@googlegroups.com always CC’d. diff --git a/codereview.settings b/codereview.settings index 707f1d99..2a60978c 100644 --- a/codereview.settings +++ b/codereview.settings @@ -1,5 +1,4 @@ -CODE_REVIEW_SERVER: codereview.chromium.org -CC_LIST: google-breakpad-dev@googlegroups.com -TRY_ON_UPLOAD: False +GERRIT_HOST: True +GERRIT_SQUASH_UPLOADS: True +CODE_REVIEW_SERVER: chromium-review.googlesource.com VIEW_VC: https://chromium.googlesource.com/breakpad/breakpad/+/ -GERRIT_SQUASH_UPLOADS: true |