aboutsummaryrefslogtreecommitdiff
path: root/README.ANDROID
diff options
context:
space:
mode:
authorMike Frysinger <vapier@chromium.org>2016-05-26 10:09:46 -0400
committerMike Frysinger <vapier@chromium.org>2016-05-26 10:09:46 -0400
commitbad9e55ea52abd1bb759b800d85aa8952e315af1 (patch)
tree9d9b7ec1f8149f14a4839a953f42a7099a503dd7 /README.ANDROID
parentelf_reader: drop unused zlib include (diff)
downloadbreakpad-bad9e55ea52abd1bb759b800d85aa8952e315af1.tar.xz
fix signed warning errors in unittests
A bunch of gtest assert statements fail due to signed warnings as unadorned constants are treated as signed integers. Mark them all unsigned to avoid that. One example (focus on the "[with ...]" blocks that show the types): In file included from src/breakpad_googletest_includes.h:33:0, from src/common/memory_unittest.cc:30: src/testing/gtest/include/gtest/gtest.h: In instantiation of 'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]': src/testing/gtest/include/gtest/gtest.h:1524:23: required from 'static testing::AssertionResult testing::internal::EqHelper<true>::Compare(const char*, const char*, const T1&, const T2&, typename testing::internal::EnableIf<(! testing::internal::is_pointer<T2>::value)>::type*) [with T1 = int; T2 = long unsigned int; typename testing::internal::EnableIf<(! testing::internal::is_pointer<T2>::value)>::type = void]' src/common/memory_unittest.cc:41:246: required from here src/testing/gtest/include/gtest/gtest.h:1448:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if (expected == actual) { ^ cc1plus: some warnings being treated as errors Makefile:5180: recipe for target 'src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o' failed make[2]: *** [src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o] Error 1 R=ted.mielczarek@gmail.com Review URL: https://codereview.chromium.org/2013893003 .
Diffstat (limited to 'README.ANDROID')
0 files changed, 0 insertions, 0 deletions