diff options
| author | Mike Frysinger <vapier@chromium.org> | 2017-02-17 00:25:04 -0500 |
|---|---|---|
| committer | Mike Frysinger <vapier@chromium.org> | 2017-02-20 18:03:14 +0000 |
| commit | 4e82b6fa11d0ca0b3d4f7afead32c1eb009f4c9b (patch) | |
| tree | 4583a3769cae5932ea5c67296697d0e58c0db423 /README.md | |
| parent | travis: add a clang build (diff) | |
| download | breakpad-4e82b6fa11d0ca0b3d4f7afead32c1eb009f4c9b.tar.xz | |
minidump: mark Read as override in derived classes
The base class here declares Read as virtual, so make sure it's
marked as override in the derived classes. This fixes some build
errors with clang.
src/google_breakpad/processor/minidump.h:853:8: error:
'Read' overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool Read(uint32_t expected_size_);
^
src/google_breakpad/processor/minidump.h:153:16: note:
overridden virtual function is here
virtual bool Read(uint32_t expected_size) = 0;
^
Change-Id: Ie4e5fec097b7f37739433a9deb39e7ed60471461
Reviewed-on: https://chromium-review.googlesource.com/444385
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Diffstat (limited to 'README.md')
0 files changed, 0 insertions, 0 deletions