diff options
| author | mark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2014-01-10 19:54:20 +0000 |
|---|---|---|
| committer | mark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2014-01-10 19:54:20 +0000 |
| commit | 3ea04ec4794537a1e392f5cad4e352f4c9722553 (patch) | |
| tree | cd342c3a630773e5ecb15a240fe30e79fcd23fab /android/sample_app/jni/test_breakpad.cpp | |
| parent | Fix #include order from r1268. (diff) | |
| download | breakpad-3ea04ec4794537a1e392f5cad4e352f4c9722553.tar.xz | |
Don't do work inside assert(). Ever.
The Mac crash key manipulation code was intended to be thread-safe through the
provision of a mutex. The mutex operations were done inside an assert().
assert() is a no-op in NDEBUG (release) builds. Therefore, in release builds,
these operations were occurring without being protected by any mutex at all,
and were nowhere near thread-safe.
BUG=chromium:331268
R=rsesek@chromium.org
Review URL: https://breakpad.appspot.com/1034002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1270 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'android/sample_app/jni/test_breakpad.cpp')
0 files changed, 0 insertions, 0 deletions