diff options
| author | mmandlis@chromium.org <mmandlis@chromium.org> | 2015-08-26 16:18:52 +0000 |
|---|---|---|
| committer | mmandlis@chromium.org <mmandlis@chromium.org> | 2015-08-26 16:18:52 +0000 |
| commit | 3f4d090d70c3f5fbeb9b6e646a079631f1ebf05b (patch) | |
| tree | 56f8dd65707ac1f792284623575c29fd70298840 /codereview.settings | |
| parent | Add check for Linux minidump ending on bad write for exploitability rating. (diff) | |
| download | breakpad-3f4d090d70c3f5fbeb9b6e646a079631f1ebf05b.tar.xz | |
The "CPU architecture" field is being filled from the wrong part of
the microdump. The microdump OS/arch line looks like:
O A arm 04 armv7l 3.4.0-perf-g4d6e88e #1 SMP PREEMPT Mon Mar 30 19:09:30 2015
and currently the field that says "armv7l" or "aarch64" is being used
to fill in the CPU arch field in crash. The problem is that on a
64-bit device this field *always* says "aarch64" even when running in
a 32-bit process, and so currently the crash reports for aarch64 are
a mix of 32-bit and 64-bit crashes. We should be using the first field
instead, which just says "arm" or "arm64" and reflects the actual
version of webview (32-bit or 64-bit) which is running.
BUG=
R=primiano@chromium.org
Review URL: https://codereview.chromium.org/1306983003 .
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1498 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'codereview.settings')
0 files changed, 0 insertions, 0 deletions