diff options
| author | vapier@chromium.org <vapier@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-12-11 05:38:34 +0000 |
|---|---|---|
| committer | vapier@chromium.org <vapier@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-12-11 05:38:34 +0000 |
| commit | 4c048c97644b0cbc77d6f982afdc7b04928ac65d (patch) | |
| tree | 3b84ead6474c8174a4ac37a4662c7bf4a320a546 /src/breakpad_googletest_includes.h | |
| parent | Address additional comments from r1248. Fix the register to check and fix som... (diff) | |
| download | breakpad-4c048c97644b0cbc77d6f982afdc7b04928ac65d.tar.xz | |
disable unittests under ASAN that use memory crashes
There are a bunch of tests that use invalid memory acesses (on purpose)
to trigger a crash so that we can detect things are dumped correctly.
When we run under ASAN, it catches those accesses and the breaks the
testing flow.
For now, use the existing ADDRESS_SANITIZER symbol to disable more tests.
Ideally we'd use a compile-time attribute to disable ASAN on a few funcs,
but that seems to be broken atm.
BUG=chromium:293519
BUG=chromium:304575
TEST=ran unittests under ASAN and they now pass
TEST=ran unittests w/out asan/clang and they still pass
R=benchan@chromium.org
Review URL: https://breakpad.appspot.com/884002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1255 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/breakpad_googletest_includes.h')
| -rw-r--r-- | src/breakpad_googletest_includes.h | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/src/breakpad_googletest_includes.h b/src/breakpad_googletest_includes.h index 48a4cc1b..1cc324b2 100644 --- a/src/breakpad_googletest_includes.h +++ b/src/breakpad_googletest_includes.h @@ -33,4 +33,25 @@ #include "testing/gtest/include/gtest/gtest.h" #include "testing/include/gmock/gmock.h" +// If AddressSanitizer is used, NULL pointer dereferences generate SIGILL +// (illegal instruction) instead of SIGSEGV (segmentation fault). Also, +// the number of memory regions differs, so there is no point in running +// this test if AddressSanitizer is used. +// +// Ideally we'd use this attribute to disable ASAN on a per-func basis, +// but this doesn't seem to actually work, and it's changed names over +// time. So just stick with disabling the actual tests. +// http://crbug.com/304575 +//#define NO_ASAN __attribute__((no_sanitize_address)) +#if defined(__clang__) && defined(__has_feature) +// Have to keep this check sep from above as newer gcc will barf on it. +# if __has_feature(address_sanitizer) +# define ADDRESS_SANITIZER +# endif +#elif defined(__GNUC__) && defined(__SANITIZE_ADDRESS__) +# define ADDRESS_SANITIZER +#else +# undef ADDRESS_SANITIZER +#endif + #endif // BREAKPAD_GOOGLETEST_INCLUDES_H__ |