diff options
| author | Jon Turney <jon.turney@dronecode.org.uk> | 2017-03-17 17:55:46 +0000 |
|---|---|---|
| committer | Mike Frysinger <vapier@chromium.org> | 2017-03-17 19:15:06 +0000 |
| commit | 0c3b559653d011bd9f171c945de1570c66fb15fc (patch) | |
| tree | ff48ed211fa8059796e8aa4df66c42d202437317 /src/client/linux/data | |
| parent | Fix issues with Windows dump_syms_unittest (diff) | |
| download | breakpad-0c3b559653d011bd9f171c945de1570c66fb15fc.tar.xz | |
Fix sporadic failure of InstructionPointerMemory test on Windows
If another memory region of interest (e.g. a thread stack) randomly happens
to lie immediately before the page allocated by this test, the memory
regions can be coalesced in the minidump generated. Relax this test so it
correctly handles the case where the expected 256 bytes around the IP aren't
at the start of the minidump memory region.
Alternatively, that could be avoided by reserving the page before the page
used for this test, in which case this test is degenerate with
InstructionPointerMemoryMinBound and can be removed.
BUG=
Change-Id: Ib1bfb242b2c0acaa090df68334a02ac434ad880c
Reviewed-on: https://chromium-review.googlesource.com/456702
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Diffstat (limited to 'src/client/linux/data')
0 files changed, 0 insertions, 0 deletions