diff options
| author | mark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-07-24 22:45:30 +0000 |
|---|---|---|
| committer | mark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-07-24 22:45:30 +0000 |
| commit | 3279794487885ea6c5ac30111a35264a51d83e4d (patch) | |
| tree | a7f8498f645e013af3a8e2b84582bfb8ff3c373e /src/client/linux/handler/exception_handler.cc | |
| parent | Back out r996, reinstating r985. That wasn't it. (diff) | |
| download | breakpad-3279794487885ea6c5ac30111a35264a51d83e4d.tar.xz | |
Speculatively back out r989 per http://codereview.chromium.org/10805065/ :
Ted Mielczarek:
> You could try backing out r989, although Mozilla has been running with that
> patch for months without issue.
Me:
> src/client/windows/handler/exception_handler.cc in r989 appears to have
> formatting problems, an unwanted property change, and no real Breakpad review
> history, so maybe we should back it out anyway until the proper process is
> followed.
NACL Tests nacl_integration failures:
http://build.chromium.org/p/chromium/builders/NACL%20Tests/builds/30138
chrome src/native_client/tests/inbrowser_crash_test/crash_dump_tester.py says
that the observed failures are a symptom of crash_service.exe itself crashing.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@998 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/linux/handler/exception_handler.cc')
| -rw-r--r-- | src/client/linux/handler/exception_handler.cc | 18 |
1 files changed, 1 insertions, 17 deletions
diff --git a/src/client/linux/handler/exception_handler.cc b/src/client/linux/handler/exception_handler.cc index fffc3e64..f505ff33 100644 --- a/src/client/linux/handler/exception_handler.cc +++ b/src/client/linux/handler/exception_handler.cc @@ -465,8 +465,7 @@ bool ExceptionHandler::DoDump(pid_t crashing_process, const void* context, crashing_process, context, context_size, - mapping_list_, - app_memory_list_); + mapping_list_); } // static @@ -516,19 +515,4 @@ void ExceptionHandler::AddMappingInfo(const string& name, mapping_list_.push_back(mapping); } -void ExceptionHandler::RegisterAppMemory(void *ptr, size_t length) { - app_memory_list_.push_back(AppMemory(ptr, length)); -} - -void ExceptionHandler::UnregisterAppMemory(void *ptr) { - for (AppMemoryList::iterator iter = app_memory_list_.begin(); - iter != app_memory_list_.end(); - ++iter) { - if (iter->ptr == ptr) { - app_memory_list_.erase(iter); - return; - } - } -} - } // namespace google_breakpad |