diff options
| author | Mike Percy <mpercy@gmail.com> | 2016-12-10 02:21:15 +0000 |
|---|---|---|
| committer | Mike Frysinger <vapier@chromium.org> | 2016-12-10 17:53:36 +0000 |
| commit | 5c42d7288a175f6d976ec0d90ced688aacd0d8b3 (patch) | |
| tree | dbf411a4f3c24339625f7190196763e3e5d39788 /src/client/linux/microdump_writer/microdump_writer_unittest.cc | |
| parent | crash_generation: fix bad call to close (diff) | |
| download | breakpad-5c42d7288a175f6d976ec0d90ced688aacd0d8b3.tar.xz | |
Fix sign-compare compiler warning in MicrodumpWriterTest
Commit 7a8980997d0e0dcf3f3a5d8ccf3c1d8c2840ea27 introduced additional
tests into MicrodumpWriterTest, two of which throw warnings which break
"make check" under default settings on Linux, because the Makefiles are
configured with -Werror=sign-compare.
This patch just makes the signedness of the assertion arguments match.
Change-Id: Ib522f44205c84f91bc9b93276fad60ebbf005f60
Reviewed-on: https://chromium-review.googlesource.com/418938
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Diffstat (limited to 'src/client/linux/microdump_writer/microdump_writer_unittest.cc')
| -rw-r--r-- | src/client/linux/microdump_writer/microdump_writer_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/client/linux/microdump_writer/microdump_writer_unittest.cc b/src/client/linux/microdump_writer/microdump_writer_unittest.cc index b3008052..b6dc69e3 100644 --- a/src/client/linux/microdump_writer/microdump_writer_unittest.cc +++ b/src/client/linux/microdump_writer/microdump_writer_unittest.cc @@ -246,7 +246,7 @@ TEST(MicrodumpWriterTest, NoOutputIfUninteresting) { MappingList no_mappings; CrashAndGetMicrodump(no_mappings, kMicrodumpExtraInfo, &buf); - ASSERT_EQ(0, buf.size()); + ASSERT_EQ(0U, buf.size()); } // Ensure that output occurs if the interest region is set, and @@ -268,7 +268,7 @@ TEST(MicrodumpWriterTest, OutputIfInteresting) { MappingList no_mappings; CrashAndGetMicrodump(no_mappings, kMicrodumpExtraInfo, &buf); - ASSERT_LT(0, buf.size()); + ASSERT_LT(0U, buf.size()); } // Ensure that the product info and build fingerprint metadata show up in the |