diff options
| author | primiano@chromium.org <primiano@chromium.org> | 2015-08-18 08:38:14 +0000 |
|---|---|---|
| committer | primiano@chromium.org <primiano@chromium.org> | 2015-08-18 08:38:14 +0000 |
| commit | 3365fe79869bdc5c25eb4da1406edcf20ddd9888 (patch) | |
| tree | 03859a16eea5d43a369d73999f5d0040cdd680f8 /src/client/linux/microdump_writer | |
| parent | Fix proc_maps_linux compile for non-Linux (diff) | |
| download | breakpad-3365fe79869bdc5c25eb4da1406edcf20ddd9888.tar.xz | |
Remove obsolete seccomp_unwinder for legacy (pre-BPF) sandbox
The PopSeccompStackFrame was introduced to deal with stack frames
originated in the legacy seccomp sandbox. The only user of that
sandbox was Google Chrome, but the legacy sandbox has been
deprecated in 2013 (crrev.com/1290643003) in favor of the new
bpf sandbox.
Removing this dead code as it has some small bound checking bug
which causes occasional crashes in WebView (which are totally
unrelated to the sandbox).
Note: this will require a corresponding change in the chromium
GYP/GN build files to roll.
BUG=665,chromium:477444
R=jln@chromium.org, mark@chromium.org, torne@chromium.org
Review URL: https://codereview.chromium.org/1299593003 .
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1492 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/linux/microdump_writer')
| -rw-r--r-- | src/client/linux/microdump_writer/microdump_writer.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/client/linux/microdump_writer/microdump_writer.cc b/src/client/linux/microdump_writer/microdump_writer.cc index c2dba35b..d2eaa6ee 100644 --- a/src/client/linux/microdump_writer/microdump_writer.cc +++ b/src/client/linux/microdump_writer/microdump_writer.cc @@ -34,7 +34,6 @@ #include <sys/utsname.h> -#include "client/linux/dump_writer_common/seccomp_unwinder.h" #include "client/linux/dump_writer_common/thread_info.h" #include "client/linux/dump_writer_common/ucontext_reader.h" #include "client/linux/handler/exception_handler.h" @@ -50,7 +49,6 @@ using google_breakpad::LinuxPtraceDumper; using google_breakpad::MappingInfo; using google_breakpad::MappingList; using google_breakpad::RawContextCPU; -using google_breakpad::SeccompUnwinder; using google_breakpad::ThreadInfo; using google_breakpad::UContextReader; @@ -287,8 +285,6 @@ class MicrodumpWriter { #else UContextReader::FillCPUContext(&cpu, ucontext_); #endif - if (stack_copy) - SeccompUnwinder::PopSeccompStackFrame(&cpu, thread, stack_copy); DumpCPUState(&cpu); } return true; |