diff options
| author | mkrebs@chromium.org <mkrebs@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-10-08 20:33:06 +0000 |
|---|---|---|
| committer | mkrebs@chromium.org <mkrebs@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-10-08 20:33:06 +0000 |
| commit | 1500c419664a0f8387f776d66ecc0b0051e44ce9 (patch) | |
| tree | 973a7b100aafe020617d46c21b096d034bf83d48 /src/client/linux/minidump_writer/linux_core_dumper.cc | |
| parent | Comment out unused arguments in definitions, as required by the Google C++ St... (diff) | |
| download | breakpad-1500c419664a0f8387f776d66ecc0b0051e44ce9.tar.xz | |
Don't bail if a thread's stack pointer is invalid
Currently, if a thread's stack pointer is not within a valid memory page,
the minidump writing will fail with an error. This change allows an invalid
stack pointer by simply setting the memory size to zero in the minidump.
The processing code already checks for the size being zero, although it
currently just gives an error (see https://breakpad.appspot.com/413002/).
BUG=google-breakpad:499, chromium-os:34880
TEST=make check, manually ran minidump-2-core and core2md
Review URL: https://breakpad.appspot.com/478002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1065 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/linux/minidump_writer/linux_core_dumper.cc')
| -rw-r--r-- | src/client/linux/minidump_writer/linux_core_dumper.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/client/linux/minidump_writer/linux_core_dumper.cc b/src/client/linux/minidump_writer/linux_core_dumper.cc index 3e8c92fe..47cc26c0 100644 --- a/src/client/linux/minidump_writer/linux_core_dumper.cc +++ b/src/client/linux/minidump_writer/linux_core_dumper.cc @@ -102,9 +102,8 @@ bool LinuxCoreDumper::GetThreadInfoByIndex(size_t index, ThreadInfo* info) { #else #error "This code hasn't been ported to your platform yet." #endif - - return GetStackInfo(&info->stack, &info->stack_len, - reinterpret_cast<uintptr_t>(stack_pointer)); + info->stack_pointer = reinterpret_cast<uintptr_t>(stack_pointer); + return true; } bool LinuxCoreDumper::IsPostMortem() const { |