diff options
| author | benchan@chromium.org <benchan@chromium.org> | 2015-02-02 23:27:27 +0000 |
|---|---|---|
| committer | benchan@chromium.org <benchan@chromium.org> | 2015-02-02 23:27:27 +0000 |
| commit | 4c01a9c389ffcfb29bb1c2a4239804019eddc3d6 (patch) | |
| tree | 6e529f8734a13e431b537dc9499a29e79beeece7 /src/client/linux/minidump_writer/linux_core_dumper.h | |
| parent | Replace uses of hash_map with unordered_map (diff) | |
| download | breakpad-4c01a9c389ffcfb29bb1c2a4239804019eddc3d6.tar.xz | |
Handle failures of copying process data from a core file.
When LinuxCoreDumper fails to copy process data from a core file, it
fills the return buffer with a repeated sequence of a special marker.
However, MinidumpWriter doesn't know about that and may incorrectly
interpret the data. In many cases, MinidumpWriter simply copies the
gibberish data to the minidump, which isn't too bad. However, the
gibberish data may cause MinidumpWriter to behave badly in some other
cases. For example, when MinidumpWriter tries to iterate through the
linked list of all loaded DSOs via the r_map field of a r_debug struct,
if the linked list is filed with the special marker, the code keeps
iterating through the same address.
This CL addresses the issue by having LinuxCoreDumper::CopyFromProcess()
returns a Boolean value to indicate if the expected data is found from
the core file. MinidumpWriter can then decide how to handle that.
BUG=chromium:453484
TEST=Run core2md with the test data attached to chromium:453484.
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/4724002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1420 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/linux/minidump_writer/linux_core_dumper.h')
| -rw-r--r-- | src/client/linux/minidump_writer/linux_core_dumper.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/client/linux/minidump_writer/linux_core_dumper.h b/src/client/linux/minidump_writer/linux_core_dumper.h index edb9e738..8537896e 100644 --- a/src/client/linux/minidump_writer/linux_core_dumper.h +++ b/src/client/linux/minidump_writer/linux_core_dumper.h @@ -68,8 +68,9 @@ class LinuxCoreDumper : public LinuxDumper { // Copies content of |length| bytes from a given process |child|, // starting from |src|, into |dest|. This method extracts the content // the core dump and fills |dest| with a sequence of marker bytes - // if the expected data is not found in the core dump. - virtual void CopyFromProcess(void* dest, pid_t child, const void* src, + // if the expected data is not found in the core dump. Returns true if + // the expected data is found in the core dump. + virtual bool CopyFromProcess(void* dest, pid_t child, const void* src, size_t length); // Implements LinuxDumper::GetThreadInfoByIndex(). |