diff options
| author | mkrebs@chromium.org <mkrebs@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-10-08 20:33:06 +0000 |
|---|---|---|
| committer | mkrebs@chromium.org <mkrebs@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-10-08 20:33:06 +0000 |
| commit | 1500c419664a0f8387f776d66ecc0b0051e44ce9 (patch) | |
| tree | 973a7b100aafe020617d46c21b096d034bf83d48 /src/client/linux/minidump_writer/linux_dumper.h | |
| parent | Comment out unused arguments in definitions, as required by the Google C++ St... (diff) | |
| download | breakpad-1500c419664a0f8387f776d66ecc0b0051e44ce9.tar.xz | |
Don't bail if a thread's stack pointer is invalid
Currently, if a thread's stack pointer is not within a valid memory page,
the minidump writing will fail with an error. This change allows an invalid
stack pointer by simply setting the memory size to zero in the minidump.
The processing code already checks for the size being zero, although it
currently just gives an error (see https://breakpad.appspot.com/413002/).
BUG=google-breakpad:499, chromium-os:34880
TEST=make check, manually ran minidump-2-core and core2md
Review URL: https://breakpad.appspot.com/478002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1065 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/linux/minidump_writer/linux_dumper.h')
| -rw-r--r-- | src/client/linux/minidump_writer/linux_dumper.h | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/client/linux/minidump_writer/linux_dumper.h b/src/client/linux/minidump_writer/linux_dumper.h index 2ed3e14d..a4a3ab5a 100644 --- a/src/client/linux/minidump_writer/linux_dumper.h +++ b/src/client/linux/minidump_writer/linux_dumper.h @@ -72,10 +72,7 @@ struct ThreadInfo { pid_t tgid; // thread group id pid_t ppid; // parent process - // Even on platforms where the stack grows down, the following will point to - // the smallest address in the stack. - const void* stack; // pointer to the stack area - size_t stack_len; // length of the stack to copy + uintptr_t stack_pointer; // thread stack pointer #if defined(__i386) || defined(__x86_64) |