diff options
author | benchan@chromium.org <benchan@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-01-11 01:31:35 +0000 |
---|---|---|
committer | benchan@chromium.org <benchan@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-01-11 01:31:35 +0000 |
commit | 577304f02af6be71c1587d3b880b2a55ac96145b (patch) | |
tree | c666d9cb5bbe02ed41a047cc816af4fd283028a9 /src/client/linux/minidump_writer/linux_dumper_unittest.cc | |
parent | Clear error state flags in binarystream::rewind(). (diff) | |
download | breakpad-577304f02af6be71c1587d3b880b2a55ac96145b.tar.xz |
Refactor LinuxDumper and MinidumpWriter.
This patch is part of a bigger patch that helps merging the breakpad code
with the modified version in Chromium OS.
Specifically, this patch makes the following changes:
1. Add two convenient methods, back() and empty(), to the wasteful_vector
class.
2. Refactor the LinuxDumper class such that it can later be splitted into
a base class and two derived classes, one uses the current ptrace
implementation and one uses a core file.
3. Refactor the MinidumpWriter class such that it can later use different
derived implementations of LinuxDumper.
BUG=455
TEST=Tested the following:
1. Build on 32-bit and 64-bit Linux with gcc 4.4.3 and gcc 4.6.
2. Build on Mac OS X 10.6.8 with gcc 4.2 and clang 3.0 (with latest gmock).
3. All unit tests pass.
Review URL: http://breakpad.appspot.com/340001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@902 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/linux/minidump_writer/linux_dumper_unittest.cc')
-rw-r--r-- | src/client/linux/minidump_writer/linux_dumper_unittest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/client/linux/minidump_writer/linux_dumper_unittest.cc b/src/client/linux/minidump_writer/linux_dumper_unittest.cc index 6f4e0e44..cf389b57 100644 --- a/src/client/linux/minidump_writer/linux_dumper_unittest.cc +++ b/src/client/linux/minidump_writer/linux_dumper_unittest.cc @@ -225,7 +225,7 @@ TEST(LinuxDumperTest, VerifyStackReadWithMultipleThreads) { ThreadInfo one_thread; for(size_t i = 0; i < dumper.threads().size(); ++i) { - EXPECT_TRUE(dumper.ThreadInfoGet(dumper.threads()[i], &one_thread)); + EXPECT_TRUE(dumper.GetThreadInfoByIndex(i, &one_thread)); // In the helper program, we stored a pointer to the thread id in a // specific register. Check that we can recover its value. #if defined(__ARM_EABI__) |