diff options
author | Tobias Sargeant <tobiasjs@google.com> | 2017-02-07 14:33:48 +0000 |
---|---|---|
committer | Tobias Sargeant <tobiasjs@chromium.org> | 2017-02-07 16:34:17 +0000 |
commit | 7ba80c728420735950f30f43095e74e9b2d294e0 (patch) | |
tree | a6619b5ec00555d1054474d962727edf331db644 /src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc | |
parent | md5: fix strict aliasing warnings (diff) | |
download | breakpad-7ba80c728420735950f30f43095e74e9b2d294e0.tar.xz |
Address post-submit review comments related to CL #430050
See: https://chromium-review.googlesource.com/c/430050/
BUG=664460
Change-Id: I3cbfbd5b00725bd501f06427eebd976267c4f617
Reviewed-on: https://chromium-review.googlesource.com/438444
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Diffstat (limited to 'src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc')
-rw-r--r-- | src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc b/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc index 59b7c61b..d693df32 100644 --- a/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc +++ b/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc @@ -80,8 +80,8 @@ pid_t SetupChildProcess(int number_of_threads) { string helper_path(GetHelperBinary()); if (helper_path.empty()) { - ADD_FAILURE() << "Couldn't find helper binary"; - return -1; + fprintf(stderr, "Couldn't find helper binary\n"); + _exit(1); } // Pass the pipe fd and the number of threads as arguments. @@ -94,8 +94,9 @@ pid_t SetupChildProcess(int number_of_threads) { NULL); // Kill if we get here. printf("Errno from exec: %d", errno); - ADD_FAILURE() << "Exec of " << helper_path << " failed: " << strerror(errno); - return -1; + std::string err_str = "Exec of " + helper_path + " failed"; + perror(err_str.c_str()); + _exit(1); } close(fds[1]); |