diff options
| author | thestig@chromium.org <thestig@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-07-24 00:15:53 +0000 |
|---|---|---|
| committer | thestig@chromium.org <thestig@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-07-24 00:15:53 +0000 |
| commit | 6b563c50dd76ba4d88a5cf4dd5e63fb9a4bacb78 (patch) | |
| tree | 0b9ff05db0c1d44683a8ae1e457062c0cb53c80c /src/client/linux/minidump_writer | |
| parent | Fix a Windows compiler warning with a cast: (diff) | |
| download | breakpad-6b563c50dd76ba4d88a5cf4dd5e63fb9a4bacb78.tar.xz | |
Linux: Fix a bunch of clang errors from not handling return values.
Review URL: https://breakpad.appspot.com/421002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@995 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/linux/minidump_writer')
| -rw-r--r-- | src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc | 5 | ||||
| -rw-r--r-- | src/client/linux/minidump_writer/minidump_writer_unittest.cc | 7 |
2 files changed, 7 insertions, 5 deletions
diff --git a/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc b/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc index 6fabfd84..61f21b86 100644 --- a/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc +++ b/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc @@ -52,6 +52,7 @@ #include "client/linux/minidump_writer/minidump_writer_unittest_utils.h" #include "common/linux/eintr_wrapper.h" #include "common/linux/file_id.h" +#include "common/linux/ignore_ret.h" #include "common/linux/safe_readlink.h" #include "common/memory.h" #include "common/using_std_string.h" @@ -343,7 +344,7 @@ TEST(LinuxPtraceDumperTest, LinuxGateMappingIDChild) { close(fds[1]); // Now wait forever for the parent. char b; - HANDLE_EINTR(read(fds[0], &b, sizeof(b))); + IGNORE_RET(HANDLE_EINTR(read(fds[0], &b, sizeof(b)))); close(fds[0]); syscall(__NR_exit); } @@ -395,7 +396,7 @@ TEST(LinuxPtraceDumperTest, FileIDsMatch) { close(fds[1]); // Now wait forever for the parent. char b; - HANDLE_EINTR(read(fds[0], &b, sizeof(b))); + IGNORE_RET(HANDLE_EINTR(read(fds[0], &b, sizeof(b)))); close(fds[0]); syscall(__NR_exit); } diff --git a/src/client/linux/minidump_writer/minidump_writer_unittest.cc b/src/client/linux/minidump_writer/minidump_writer_unittest.cc index be6be139..4f69013a 100644 --- a/src/client/linux/minidump_writer/minidump_writer_unittest.cc +++ b/src/client/linux/minidump_writer/minidump_writer_unittest.cc @@ -44,6 +44,7 @@ #include "client/linux/minidump_writer/minidump_writer_unittest_utils.h" #include "common/linux/eintr_wrapper.h" #include "common/linux/file_id.h" +#include "common/linux/ignore_ret.h" #include "common/linux/safe_readlink.h" #include "common/tests/auto_tempdir.h" #include "common/using_std_string.h" @@ -68,7 +69,7 @@ TEST(MinidumpWriterTest, Setup) { if (child == 0) { close(fds[1]); char b; - HANDLE_EINTR(read(fds[0], &b, sizeof(b))); + IGNORE_RET(HANDLE_EINTR(read(fds[0], &b, sizeof(b)))); close(fds[0]); syscall(__NR_exit); } @@ -132,7 +133,7 @@ TEST(MinidumpWriterTest, MappingInfo) { if (child == 0) { close(fds[1]); char b; - HANDLE_EINTR(read(fds[0], &b, sizeof(b))); + IGNORE_RET(HANDLE_EINTR(read(fds[0], &b, sizeof(b)))); close(fds[0]); syscall(__NR_exit); } @@ -237,7 +238,7 @@ TEST(MinidumpWriterTest, MappingInfoContained) { if (child == 0) { close(fds[1]); char b; - HANDLE_EINTR(read(fds[0], &b, sizeof(b))); + IGNORE_RET(HANDLE_EINTR(read(fds[0], &b, sizeof(b)))); close(fds[0]); syscall(__NR_exit); } |