diff options
author | rmcilroy@chromium.org <rmcilroy@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2014-07-18 13:14:37 +0000 |
---|---|---|
committer | rmcilroy@chromium.org <rmcilroy@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2014-07-18 13:14:37 +0000 |
commit | 8703844b3c51a80112dbee3ed4bc01a85603e165 (patch) | |
tree | 1b04a57b8d8bba13412a22d50030ef425e08744e /src/client/linux/minidump_writer | |
parent | Add frame pointer recovery to the AMD64 Stackwalker. (diff) | |
download | breakpad-8703844b3c51a80112dbee3ed4bc01a85603e165.tar.xz |
[Android]: Remove __system_property_get(ro.build.fingerprint) from WriteOSInformation.
__system_property_get has been removed from the Android NDK for 'L' so Breakpad
no longer links. This CL just removes the call in WriteOSInformation because
Chrome already passes the build fingerprint as a crash key called "android_build_fp" in the crash report HTTP POST message.
BUG=394841,393903
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/1694002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1351 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/linux/minidump_writer')
-rw-r--r-- | src/client/linux/minidump_writer/minidump_writer.cc | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/src/client/linux/minidump_writer/minidump_writer.cc b/src/client/linux/minidump_writer/minidump_writer.cc index 43c1ef2c..fa2ad9e1 100644 --- a/src/client/linux/minidump_writer/minidump_writer.cc +++ b/src/client/linux/minidump_writer/minidump_writer.cc @@ -1758,23 +1758,6 @@ class MinidumpWriter { space_left -= info_len; } -#ifdef __ANDROID__ - // On Android, try to get the build fingerprint and append it. - // Fail gracefully because there is no guarantee that the system - // property will always be available or accessible. - char fingerprint[PROP_VALUE_MAX]; - int fingerprint_len = __system_property_get("ro.build.fingerprint", - fingerprint); - // System property values shall always be zero-terminated. - // Be paranoid and don't trust the system. - if (fingerprint_len > 0 && fingerprint_len < PROP_VALUE_MAX) { - const char* separator = " "; - if (!first_item) - my_strlcat(buf, separator, sizeof(buf)); - my_strlcat(buf, fingerprint, sizeof(buf)); - } -#endif - MDLocationDescriptor location; if (!minidump_writer_.WriteString(buf, 0, &location)) return false; |