diff options
| author | mark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2011-08-25 21:19:29 +0000 |
|---|---|---|
| committer | mark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2011-08-25 21:19:29 +0000 |
| commit | 60a883212fbe065f37da2ffdeca2bbe22742c7e8 (patch) | |
| tree | 9c8a4f5609f9ac5165f0b76e53a42b40c407e4cd /src/client/mac/handler/minidump_generator.h | |
| parent | The process_id field is unsigned, so we need this cast in c++0x. (diff) | |
| download | breakpad-60a883212fbe065f37da2ffdeca2bbe22742c7e8.tar.xz | |
Fix CalculateStackSize to behave properly when the main thread's stack is
split up into multiple regions.
An older workaround relyied on known fixed stack locations and only filled in
the initial page of the stack if it was in a distinct region. The new approach
looks upwards for additional regions that appear to be part of the same stack.
With PIE on Lion, the stack no longer begins at a fixed address, so the older
workaround became ineffective.
BUG=247, chromium:94107
TEST=Stacks should run through to _main/start and then stop when examining
Chrome on Lion with PIE and "slid" stacks.
Review URL: http://breakpad.appspot.com/300001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@826 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/mac/handler/minidump_generator.h')
| -rw-r--r-- | src/client/mac/handler/minidump_generator.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/client/mac/handler/minidump_generator.h b/src/client/mac/handler/minidump_generator.h index 55c4c8a3..6f9fe8f7 100644 --- a/src/client/mac/handler/minidump_generator.h +++ b/src/client/mac/handler/minidump_generator.h @@ -51,9 +51,6 @@ namespace google_breakpad { using std::string; -const u_int64_t TOP_OF_THREAD0_STACK_64BIT = 0x00007fff5fbff000LL; -const u_int32_t TOP_OF_THREAD0_STACK_32BIT = 0xbffff000; - // Use the REGISTER_FROM_THREADSTATE to access a register name from the // breakpad_thread_state_t structure. #if __DARWIN_UNIX03 || TARGET_CPU_X86_64 || TARGET_CPU_PPC64 |