diff options
author | nealsid <nealsid@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2008-04-29 23:49:39 +0000 |
---|---|---|
committer | nealsid <nealsid@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2008-04-29 23:49:39 +0000 |
commit | d906d0f7c974fba444a117ee4b8000f60da07923 (patch) | |
tree | d16133ea9389ad69db41721dc7255202fbe80856 /src/client/mac/handler/testcases/breakpad_nlist_test.cc | |
parent | Issue 258: Added test cases for ReadTaskMemory, reorganized project file, ren... (diff) | |
download | breakpad-d906d0f7c974fba444a117ee4b8000f60da07923.tar.xz |
Updated code to be compliant with style guidelines
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@264 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/mac/handler/testcases/breakpad_nlist_test.cc')
-rw-r--r-- | src/client/mac/handler/testcases/breakpad_nlist_test.cc | 65 |
1 files changed, 45 insertions, 20 deletions
diff --git a/src/client/mac/handler/testcases/breakpad_nlist_test.cc b/src/client/mac/handler/testcases/breakpad_nlist_test.cc index 990739dc..df3c86e9 100644 --- a/src/client/mac/handler/testcases/breakpad_nlist_test.cc +++ b/src/client/mac/handler/testcases/breakpad_nlist_test.cc @@ -1,15 +1,42 @@ -/* - * breakpad_nlist_test.cc - * minidump_test - * - * Created by Neal Sidhwaney on 4/13/08. - * Copyright 2008 Google Inc. All rights reserved. - * - */ - -#include "breakpad_nlist_test.h" +// Copyright (c) 2008, Google Inc. +// All rights reserved +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following disclaimer +// in the documentation and/or other materials provided with the +// distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived from +// this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// +// breakpad_nlist_test.cc +// minidump_test +// +// Created by Neal Sidhwaney on 4/13/08. +// Copyright 2008 Google Inc. All rights reserved. +// + +#include "client/mac/handler/testcases/breakpad_nlist_test.h" #include <mach-o/nlist.h> -#include "breakpad_nlist_64.h" +#include "client/mac/handler/breakpad_nlist_64.h" BreakpadNlistTest test1(TEST_INVOCATION(BreakpadNlistTest, CompareToNM)); @@ -28,13 +55,13 @@ void BreakpadNlistTest::CompareToNM() { system("/usr/bin/nm -arch ppc64 /usr/lib/dyld > /tmp/dyld-namelist.txt"); #endif - FILE *fd = fopen("/tmp/dyld-namelist.txt","rt"); + FILE *fd = fopen("/tmp/dyld-namelist.txt", "rt"); char oneNMAddr[30]; char symbolType; char symbolName[500]; - while(!feof(fd)) { - fscanf(fd,"%s %c %s",oneNMAddr, &symbolType, symbolName); + while (!feof(fd)) { + fscanf(fd, "%s %c %s", oneNMAddr, &symbolType, symbolName); breakpad_nlist symbolList[2]; breakpad_nlist &list = symbolList[0]; @@ -44,7 +71,7 @@ void BreakpadNlistTest::CompareToNM() { symbolNames[1] = "\0"; breakpad_nlist_64("/usr/lib/dyld",&list, symbolNames); uint64_t nmAddr = strtol(oneNMAddr,NULL,16); - if(!IsSymbolMoreThanOnceInDyld(symbolName)) { + if (!IsSymbolMoreThanOnceInDyld(symbolName)) { CPTAssert(nmAddr == symbolList[0].n_value); } } @@ -53,7 +80,7 @@ void BreakpadNlistTest::CompareToNM() { } bool BreakpadNlistTest::IsSymbolMoreThanOnceInDyld(const char *symbolName) { - //These are the symbols that occur more than once when nm dumps + // These are the symbols that occur more than once when nm dumps // the symbol table of /usr/lib/dyld. Our nlist program returns // the first address because it's doing a search so we need to exclude // these from causing the test to fail @@ -68,14 +95,12 @@ bool BreakpadNlistTest::IsSymbolMoreThanOnceInDyld(const char *symbolName) { bool found = false; - for(int i = 0; multipleSymbols[i][0]; i++) { - if(!strcmp(multipleSymbols[i],symbolName)) { + for (int i = 0; multipleSymbols[i][0]; i++) { + if (!strcmp(multipleSymbols[i], symbolName)) { found = true; break; } - } return found; - } |