diff options
author | nealsid <nealsid@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2009-05-15 17:54:20 +0000 |
---|---|---|
committer | nealsid <nealsid@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2009-05-15 17:54:20 +0000 |
commit | bec07f697242bbc5613fbdb6922953e8694adc57 (patch) | |
tree | 6a533dd93cb7f0312574a7538c67674899b61d85 /src/client/mac/handler | |
parent | Fix memory leak in test case when calling into basic source line resolver. (diff) | |
download | breakpad-bec07f697242bbc5613fbdb6922953e8694adc57.tar.xz |
Patch from Jeremy to have better error reporting, and workaround a Cocoa bug in different locales
R=nealsid
A=jeremy
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@339 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/mac/handler')
-rw-r--r-- | src/client/mac/handler/minidump_generator.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/client/mac/handler/minidump_generator.cc b/src/client/mac/handler/minidump_generator.cc index b3091d4d..13db2474 100644 --- a/src/client/mac/handler/minidump_generator.cc +++ b/src/client/mac/handler/minidump_generator.cc @@ -172,7 +172,7 @@ bool MinidumpGenerator::Write(const char *path) { // exception. &MinidumpGenerator::WriteExceptionStream, }; - bool result = true; + bool result = false; // If opening was successful, create the header, directory, and call each // writer. The destructor for the TypedMDRVAs will cause the data to be @@ -203,6 +203,7 @@ bool MinidumpGenerator::Write(const char *path) { header_ptr->stream_directory_rva = dir.position(); MDRawDirectory local_dir; + result = true; for (int i = 0; (result) && (i < writer_count); ++i) { result = (this->*writers[i])(&local_dir); |