diff options
author | Peter Collingbourne <pcc@google.com> | 2017-05-26 09:32:08 -0700 |
---|---|---|
committer | Primiano Tucci <primiano@chromium.org> | 2017-05-26 16:51:46 +0000 |
commit | 94b6309aecaddfcf11672f6cfad9575d68ad3b40 (patch) | |
tree | 752ec6003a48bcdce47ada327dc4f2e43e878822 /src/client/mac/sender/fr.lproj/Localizable.strings | |
parent | Teach the ELF parser to handle multiple PT_NOTE phdrs. (diff) | |
download | breakpad-94b6309aecaddfcf11672f6cfad9575d68ad3b40.tar.xz |
Merge exec and non-exec segments while merging executable bit.
The bfd and gold linkers create segments like this: r/x, r/w where
the r/x segment covers the start of the ELF file.
lld's segments look like this: r, r/x, r/w where the r segment covers
the start of the ELF file.
So we cannot rely on the location of the r/x to tell where the start
of the ELF is. But we can still rely on the r and r/x mappings being
adjacent. So what we do is when we see an r segment followed by an r/x,
merge the r into the r/x and claim that it is executable. This way,
the minidump writer will continue to see a single executable segment
covering the entire executable.
Testing: "make check" passes when breakpad is compiled with
lld compiled from trunk (requires bug fix from LLVM r303689).
Also patched change into chromium and tested these builds:
$ cat args.gn
is_chrome_branded = true
is_debug = false
is_official_build = true
use_lld = true
allow_posix_link_time_opt = false
is_cfi = false
$ cat args.gn
target_os = "android"
target_cpu = "arm"
is_debug = false
is_official_build = true
is_chrome_branded = true
With both builds breakpad_unittests passes and
chrome/chrome_modern_public_apk create good minidumps after navigating
to chrome://inducebrowsercrashforrealz (checked that minidump contains
stack trace entry for content::HandleDebugURL).
Bug: chromium:716484
Change-Id: Ib6ed3a8420b83acf4a5962843930fb006734cb95
Reviewed-on: https://chromium-review.googlesource.com/513610
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Diffstat (limited to 'src/client/mac/sender/fr.lproj/Localizable.strings')
0 files changed, 0 insertions, 0 deletions