diff options
author | ivan.penkov@gmail.com <ivan.penkov@gmail.com@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-06-04 16:51:01 +0000 |
---|---|---|
committer | ivan.penkov@gmail.com <ivan.penkov@gmail.com@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-06-04 16:51:01 +0000 |
commit | 6b46d4e872bfb6174a4832ab4d3a2d2c38d2cf4a (patch) | |
tree | 581ec70cc25a1a0958206d151993e270b37a49ee /src/client/windows/build | |
parent | Thanks to Matthew Riley who noticed this issue and provided the initial propo... (diff) | |
download | breakpad-6b46d4e872bfb6174a4832ab4d3a2d2c38d2cf4a.tar.xz |
Treat warnings as error and fix most level 4 warnings in the breakpad windows client projects.
Some of the lint errors in the files touched by this change were also fixed.
BUG=533
Review URL: https://breakpad.appspot.com/601002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1189 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/windows/build')
-rw-r--r-- | src/client/windows/build/common.gypi | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/client/windows/build/common.gypi b/src/client/windows/build/common.gypi index dfd29bd0..60a24582 100644 --- a/src/client/windows/build/common.gypi +++ b/src/client/windows/build/common.gypi @@ -507,7 +507,7 @@ 'msvs_disabled_warnings': [4800], 'msvs_settings': { 'VCCLCompilerTool': { - 'WarnAsError': 'false', + 'WarnAsError': 'true', 'Detect64BitPortabilityProblems': 'false', }, }, @@ -1174,7 +1174,7 @@ '$(VSInstallDir)/VC/atlmfc/include', ], 'msvs_cygwin_dirs': ['<(DEPTH)/third_party/cygwin'], - 'msvs_disabled_warnings': [4396, 4503, 4819], + 'msvs_disabled_warnings': [4100, 4127, 4396, 4503, 4512, 4819, 4995], 'msvs_settings': { 'VCCLCompilerTool': { 'MinimalRebuild': 'false', @@ -1182,7 +1182,7 @@ 'BufferSecurityCheck': 'true', 'EnableFunctionLevelLinking': 'true', 'RuntimeTypeInfo': 'false', - 'WarningLevel': '3', + 'WarningLevel': '4', 'WarnAsError': 'true', 'DebugInformationFormat': '3', 'conditions': [ |