diff options
author | ted.mielczarek <ted.mielczarek@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2010-05-19 13:40:59 +0000 |
---|---|---|
committer | ted.mielczarek <ted.mielczarek@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2010-05-19 13:40:59 +0000 |
commit | b0059c54da965f60e06d6f5d8d3ac32c014fad91 (patch) | |
tree | ca10831f07f5a9ce54e8d6400635c97338d50483 /src/client/windows/crash_generation/client_info.cc | |
parent | Patch from Vitaly to remove synchronization and make exception handling code ... (diff) | |
download | breakpad-b0059c54da965f60e06d6f5d8d3ac32c014fad91.tar.xz |
Issue 384 - UnregisterWait error handling is incorrect. Patch by Benjamin Smedberg <benjamin@smedbergs.us>, r=doshimun at http://breakpad.appspot.com/107001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@603 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/windows/crash_generation/client_info.cc')
-rw-r--r-- | src/client/windows/crash_generation/client_info.cc | 20 |
1 files changed, 5 insertions, 15 deletions
diff --git a/src/client/windows/crash_generation/client_info.cc b/src/client/windows/crash_generation/client_info.cc index 4752c4ae..94f9c3cd 100644 --- a/src/client/windows/crash_generation/client_info.cc +++ b/src/client/windows/crash_generation/client_info.cc @@ -101,26 +101,16 @@ ClientInfo::~ClientInfo() { } } -bool ClientInfo::UnregisterWaits() { - bool success = true; - +void ClientInfo::UnregisterWaits() { if (dump_request_wait_handle_) { - if (!UnregisterWait(dump_request_wait_handle_)) { - success = false; - } else { - dump_request_wait_handle_ = NULL; - } + UnregisterWait(dump_request_wait_handle_); + dump_request_wait_handle_ = NULL; } if (process_exit_wait_handle_) { - if (!UnregisterWait(process_exit_wait_handle_)) { - success = false; - } else { - process_exit_wait_handle_ = NULL; - } + UnregisterWait(process_exit_wait_handle_); + process_exit_wait_handle_ = NULL; } - - return success; } bool ClientInfo::GetClientExceptionInfo(EXCEPTION_POINTERS** ex_info) const { |