diff options
| author | ivan.penkov@gmail.com <ivan.penkov@gmail.com@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-06-04 16:51:01 +0000 |
|---|---|---|
| committer | ivan.penkov@gmail.com <ivan.penkov@gmail.com@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-06-04 16:51:01 +0000 |
| commit | 6b46d4e872bfb6174a4832ab4d3a2d2c38d2cf4a (patch) | |
| tree | 581ec70cc25a1a0958206d151993e270b37a49ee /src/client/windows/handler/exception_handler.cc | |
| parent | Thanks to Matthew Riley who noticed this issue and provided the initial propo... (diff) | |
| download | breakpad-6b46d4e872bfb6174a4832ab4d3a2d2c38d2cf4a.tar.xz | |
Treat warnings as error and fix most level 4 warnings in the breakpad windows client projects.
Some of the lint errors in the files touched by this change were also fixed.
BUG=533
Review URL: https://breakpad.appspot.com/601002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1189 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/windows/handler/exception_handler.cc')
| -rw-r--r-- | src/client/windows/handler/exception_handler.cc | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/src/client/windows/handler/exception_handler.cc b/src/client/windows/handler/exception_handler.cc index 14c2cf86..3a2f824c 100644 --- a/src/client/windows/handler/exception_handler.cc +++ b/src/client/windows/handler/exception_handler.cc @@ -96,7 +96,7 @@ ExceptionHandler::ExceptionHandler(const wstring& dump_path, pipe_handle, NULL, // crash_generation_client custom_info); -} +} ExceptionHandler::ExceptionHandler( const wstring& dump_path, @@ -104,19 +104,19 @@ ExceptionHandler::ExceptionHandler( MinidumpCallback callback, void* callback_context, int handler_types, - MINIDUMP_TYPE dump_type, - CrashGenerationClient* crash_generation_client, - const CustomClientInfo* custom_info) { + CrashGenerationClient* crash_generation_client) { + // The dump_type, pipe_name and custom_info that are passed in to Initialize() + // are not used. The ones set in crash_generation_client are used instead. Initialize(dump_path, filter, callback, callback_context, handler_types, - MiniDumpNormal, - NULL, // pipe_name - NULL, // pipe_handle + MiniDumpNormal, // dump_type - not used + NULL, // pipe_name - not used + NULL, // pipe_handle crash_generation_client, - custom_info); + NULL); // custom_info - not used } ExceptionHandler::ExceptionHandler(const wstring &dump_path, @@ -875,7 +875,7 @@ BOOL CALLBACK ExceptionHandler::MinidumpWriteDumpCallback( callback_context->iter++; return TRUE; } - + // Include all modules. case IncludeModuleCallback: case ModuleCallback: |