diff options
| author | wfh@chromium.org <wfh@chromium.org> | 2015-07-10 20:24:33 +0000 |
|---|---|---|
| committer | wfh@chromium.org <wfh@chromium.org> | 2015-07-10 20:24:33 +0000 |
| commit | 0c426387b83d2f42e0a64981c2915b850fbbf09b (patch) | |
| tree | 098ec2adf432a1542015db0d306bcd749ced37bc /src/client/windows | |
| parent | Default nil or empty version string to CFBundleVersion (diff) | |
| download | breakpad-0c426387b83d2f42e0a64981c2915b850fbbf09b.tar.xz | |
Fix -Wreorder warnings in the Windows code.
This makes the order of fields in constructor initializer lists match
the order in which the fields are declared in (which is the order
they're initialized in). No intended behavior change.
This change was originally reviewed at
https://codereview.chromium.org/1230923005/
BUG=chromium:505304
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1234653002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1471 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/windows')
3 files changed, 14 insertions, 14 deletions
diff --git a/src/client/windows/crash_generation/crash_generation_client.cc b/src/client/windows/crash_generation/crash_generation_client.cc index 1e86dcec..3ba5d4e4 100644 --- a/src/client/windows/crash_generation/crash_generation_client.cc +++ b/src/client/windows/crash_generation/crash_generation_client.cc @@ -96,14 +96,14 @@ CrashGenerationClient::CrashGenerationClient( const CustomClientInfo* custom_info) : pipe_name_(pipe_name), pipe_handle_(NULL), + custom_info_(), dump_type_(dump_type), - thread_id_(0), - server_process_id_(0), crash_event_(NULL), crash_generated_(NULL), server_alive_(NULL), - exception_pointers_(NULL), - custom_info_() { + server_process_id_(0), + thread_id_(0), + exception_pointers_(NULL) { memset(&assert_info_, 0, sizeof(assert_info_)); if (custom_info) { custom_info_ = *custom_info; @@ -116,14 +116,14 @@ CrashGenerationClient::CrashGenerationClient( const CustomClientInfo* custom_info) : pipe_name_(), pipe_handle_(pipe_handle), + custom_info_(), dump_type_(dump_type), - thread_id_(0), - server_process_id_(0), crash_event_(NULL), crash_generated_(NULL), server_alive_(NULL), - exception_pointers_(NULL), - custom_info_() { + server_process_id_(0), + thread_id_(0), + exception_pointers_(NULL) { memset(&assert_info_, 0, sizeof(assert_info_)); if (custom_info) { custom_info_ = *custom_info; diff --git a/src/client/windows/crash_generation/crash_generation_server.cc b/src/client/windows/crash_generation/crash_generation_server.cc index ae05243c..2c4f072c 100644 --- a/src/client/windows/crash_generation/crash_generation_server.cc +++ b/src/client/windows/crash_generation/crash_generation_server.cc @@ -121,12 +121,12 @@ CrashGenerationServer::CrashGenerationServer( upload_request_callback_(upload_request_callback), upload_context_(upload_context), generate_dumps_(generate_dumps), + pre_fetch_custom_info_(true), dump_path_(dump_path ? *dump_path : L""), server_state_(IPC_SERVER_STATE_UNINITIALIZED), shutting_down_(false), overlapped_(), - client_info_(NULL), - pre_fetch_custom_info_(true) { + client_info_(NULL) { InitializeCriticalSection(&sync_); } diff --git a/src/client/windows/crash_generation/minidump_generator.cc b/src/client/windows/crash_generation/minidump_generator.cc index c3e91681..786c9b93 100644 --- a/src/client/windows/crash_generation/minidump_generator.cc +++ b/src/client/windows/crash_generation/minidump_generator.cc @@ -259,8 +259,9 @@ MinidumpGenerator::MinidumpGenerator( const MINIDUMP_TYPE dump_type, const bool is_client_pointers) : dbghelp_module_(NULL), + write_dump_(NULL), rpcrt4_module_(NULL), - dump_path_(dump_path), + create_uuid_(NULL), process_handle_(process_handle), process_id_(process_id), thread_id_(thread_id), @@ -269,14 +270,13 @@ MinidumpGenerator::MinidumpGenerator( assert_info_(assert_info), dump_type_(dump_type), is_client_pointers_(is_client_pointers), + dump_path_(dump_path), dump_file_(INVALID_HANDLE_VALUE), full_dump_file_(INVALID_HANDLE_VALUE), dump_file_is_internal_(false), full_dump_file_is_internal_(false), additional_streams_(NULL), - callback_info_(NULL), - write_dump_(NULL), - create_uuid_(NULL) { + callback_info_(NULL) { InitializeCriticalSection(&module_load_sync_); InitializeCriticalSection(&get_proc_address_sync_); } |