diff options
| author | ivanpe@chromium.org <ivanpe@chromium.org> | 2014-10-15 17:15:55 +0000 |
|---|---|---|
| committer | ivanpe@chromium.org <ivanpe@chromium.org> | 2014-10-15 17:15:55 +0000 |
| commit | 962f1b0e60eca939232dc0d46780da4fdbbcfd85 (patch) | |
| tree | 93a13610afe36ac94e26a40b56d1eef89c1f5611 /src/client/windows | |
| parent | Linux multiprocess crash reporter: use pipe instead of socketpair in the client (diff) | |
| download | breakpad-962f1b0e60eca939232dc0d46780da4fdbbcfd85.tar.xz | |
The process uptime computation when the Windows out-of-process Crash Generation
Server is used is done by subtracting the crashing process creation time from
the current time when the crash is generated:
uptime = now - process_creation_time
There was a bug and instead of the process creation time the code was using the
time when the process was registered with the Crash Generation Server.
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/1744002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1391 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client/windows')
| -rw-r--r-- | src/client/windows/crash_generation/client_info.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/client/windows/crash_generation/client_info.cc b/src/client/windows/crash_generation/client_info.cc index cd3a18de..ed312638 100644 --- a/src/client/windows/crash_generation/client_info.cc +++ b/src/client/windows/crash_generation/client_info.cc @@ -67,8 +67,10 @@ bool ClientInfo::Initialize() { // The crash_id will be the low order word of the process creation time. FILETIME creation_time, exit_time, kernel_time, user_time; if (GetProcessTimes(process_handle_, &creation_time, &exit_time, - &kernel_time, &user_time)) - crash_id_ = creation_time.dwLowDateTime; + &kernel_time, &user_time)) { + start_time_ = creation_time; + } + crash_id_ = start_time_.dwLowDateTime; dump_requested_handle_ = CreateEvent(NULL, // Security attributes. TRUE, // Manual reset. |