diff options
| author | Mike Frysinger <vapier@chromium.org> | 2016-11-23 18:03:18 -0500 |
|---|---|---|
| committer | Mike Frysinger <vapier@chromium.org> | 2016-12-09 15:56:26 +0000 |
| commit | c13d6fa467910dad6f32ef492f1e505c96606243 (patch) | |
| tree | 2509ca520ae47c45708a2da3cca8ec93b5bcd199 /src/client | |
| parent | Log a message when microdump output is suppressed. (diff) | |
| download | breakpad-c13d6fa467910dad6f32ef492f1e505c96606243.tar.xz | |
crash_generation: fix bad call to close
If signal_fd is -1 still, we end up calling close(-1). Not generally
a problem, but it's bad form, and coverity is upset by it.
Change-Id: I46f9c7ca4be7b43af5b609dd8e3f03a0700af418
Reviewed-on: https://chromium-review.googlesource.com/414544
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Diffstat (limited to 'src/client')
| -rw-r--r-- | src/client/linux/crash_generation/crash_generation_server.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/client/linux/crash_generation/crash_generation_server.cc b/src/client/linux/crash_generation/crash_generation_server.cc index 1d7d93b9..26c50a5c 100644 --- a/src/client/linux/crash_generation/crash_generation_server.cc +++ b/src/client/linux/crash_generation/crash_generation_server.cc @@ -255,7 +255,7 @@ CrashGenerationServer::ClientEvent(short revents) } if (crashing_pid == -1 || signal_fd == -1) { - if (signal_fd) + if (signal_fd != -1) close(signal_fd); return true; } |