diff options
| author | nealsid <nealsid@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2008-05-07 21:15:12 +0000 |
|---|---|---|
| committer | nealsid <nealsid@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2008-05-07 21:15:12 +0000 |
| commit | c2bdaa613ccc9f4528743dfd1860d108c7b7a0c8 (patch) | |
| tree | 1472a45fa0d2326df9934f2dd00e9066af9849ea /src/client | |
| parent | Add a convenience method to CustomClientInfo struct to set both name and valu... (diff) | |
| download | breakpad-c2bdaa613ccc9f4528743dfd1860d108c7b7a0c8.tar.xz | |
Bug fix for issue 263: mach_vm_region_recurse calls have invalid parameter specified, which succeeds on Leopard but fails on Tiger
Reviewer: Chris Rogers(ladderbreaker)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@269 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client')
| -rw-r--r-- | src/client/mac/handler/dynamic_images.cc | 4 | ||||
| -rw-r--r-- | src/client/mac/handler/minidump_generator.cc | 5 |
2 files changed, 4 insertions, 5 deletions
diff --git a/src/client/mac/handler/dynamic_images.cc b/src/client/mac/handler/dynamic_images.cc index 9f5e0fc9..2c2918f5 100644 --- a/src/client/mac/handler/dynamic_images.cc +++ b/src/client/mac/handler/dynamic_images.cc @@ -55,8 +55,8 @@ static mach_vm_size_t GetMemoryRegionSize(task_port_t target_task, mach_vm_address_t region_base = (mach_vm_address_t)address; mach_vm_size_t region_size; natural_t nesting_level = 0; - vm_region_submap_info submap_info; - mach_msg_type_number_t info_count = VM_REGION_SUBMAP_INFO_COUNT; + vm_region_submap_info_64 submap_info; + mach_msg_type_number_t info_count = VM_REGION_SUBMAP_INFO_COUNT_64; // Get information about the vm region containing |address| vm_region_recurse_info_t region_info; diff --git a/src/client/mac/handler/minidump_generator.cc b/src/client/mac/handler/minidump_generator.cc index ce345856..75a24b58 100644 --- a/src/client/mac/handler/minidump_generator.cc +++ b/src/client/mac/handler/minidump_generator.cc @@ -210,7 +210,6 @@ bool MinidumpGenerator::Write(const char *path) { dir.CopyIndex(i, &local_dir); } } - return result; } @@ -218,8 +217,8 @@ size_t MinidumpGenerator::CalculateStackSize(mach_vm_address_t start_addr) { mach_vm_address_t stack_region_base = start_addr; mach_vm_size_t stack_region_size; natural_t nesting_level = 0; - vm_region_submap_info submap_info; - mach_msg_type_number_t info_count = VM_REGION_SUBMAP_INFO_COUNT; + vm_region_submap_info_64 submap_info; + mach_msg_type_number_t info_count = VM_REGION_SUBMAP_INFO_COUNT_64; vm_region_recurse_info_t region_info; region_info = reinterpret_cast<vm_region_recurse_info_t>(&submap_info); |