diff options
| author | qsr@chromium.org <qsr@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-11-26 10:38:55 +0000 |
|---|---|---|
| committer | qsr@chromium.org <qsr@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-11-26 10:38:55 +0000 |
| commit | f546e072ceef20b8df684bdf86345b671ef23023 (patch) | |
| tree | 8c9d0d7878edc33629eb2cc84de4a73543c21057 /src/client | |
| parent | Process minidumps generated on ARM64 in iOS apps. (diff) | |
| download | breakpad-f546e072ceef20b8df684bdf86345b671ef23023.tar.xz | |
In iOS, BREAKPAD_OUTPUT_DUMP_FILE value contains a malformed full path to the dump file.
The std::string dumpFilename already contains the full pathname to the dump file. Appending it to the dumpDirAsNSString creates a string with the path portion duplicated, e.g.:
/var/mobile/Applications/516BE756-DFD4-4F9B-85D5-85966B0038F7/Library/Caches/Breakpad/var/mobile/Applications/516BE756-DFD4-4F9B-85D5-85966B0038F7/Library/Caches/Breakpad/0A406D28-437D-48EE-9989-23F7F871818E.dmp
Instead of this:
/var/mobile/Applications/516BE756-DFD4-4F9B-85D5-85966B0038F7/Library/Caches/Breakpad/0A406D28-437D-48EE-9989-23F7F871818E.dmp
R=markus@chromium.org, qsr@chromium.org
Review URL: https://breakpad.appspot.com/744002
Patch from Akiva <scirsw@gmail.com>.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1237 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client')
| -rw-r--r-- | src/client/ios/Breakpad.mm | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/client/ios/Breakpad.mm b/src/client/ios/Breakpad.mm index 44a61ff4..a0932831 100644 --- a/src/client/ios/Breakpad.mm +++ b/src/client/ios/Breakpad.mm @@ -519,8 +519,7 @@ NSDictionary *Breakpad::GenerateReport(NSDictionary *server_parameters) { // Handle results. NSMutableDictionary *result = [NSMutableDictionary dictionary]; - NSString *dumpFullPath = [dumpDirAsNSString stringByAppendingPathComponent: - [NSString stringWithUTF8String:dumpFilename.c_str()]]; + NSString *dumpFullPath = [NSString stringWithUTF8String:dumpFilename.c_str()]; [result setValue:dumpFullPath forKey:@BREAKPAD_OUTPUT_DUMP_FILE]; [result setValue:[NSString stringWithUTF8String:config_file.GetFilePath()] |