diff options
| author | Scott Graham <scottmg@chromium.org> | 2016-11-01 15:05:10 -0700 |
|---|---|---|
| committer | Scott Graham <scottmg@chromium.org> | 2016-11-02 02:52:37 +0000 |
| commit | 1f574b52c6c34e457b16bc451a52874dde91e4b0 (patch) | |
| tree | d0e1072d3924cb969892d0e187af06d3b7275558 /src/common/dwarf/dwarf2reader.h | |
| parent | minidump-2-core: add more control over filenames (diff) | |
| download | breakpad-1f574b52c6c34e457b16bc451a52874dde91e4b0.tar.xz | |
Basic handling of CIE version 4 in dwarf reading
CIE looks like it's been emitted by clang since ~May 2015 [1]. This
means that we didn't have any CFI because this parse aborted, which
meant that all stack walks reverted to stack scanning. Allow expected
values for address size and segment descriptor size through so that
dump_syms can generate at least somewhat reasonable data.
[1]: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150518/277292.html
R=mark@chromium.org
BUG=chromium:627529
Change-Id: I6dc92f51c4afd25c2adff92c09ccb8bb03bf9112
Reviewed-on: https://chromium-review.googlesource.com/406012
Reviewed-by: Mark Mentovai <mark@chromium.org>
Diffstat (limited to 'src/common/dwarf/dwarf2reader.h')
| -rw-r--r-- | src/common/dwarf/dwarf2reader.h | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/common/dwarf/dwarf2reader.h b/src/common/dwarf/dwarf2reader.h index 064c42bc..5d2d7f60 100644 --- a/src/common/dwarf/dwarf2reader.h +++ b/src/common/dwarf/dwarf2reader.h @@ -1227,6 +1227,14 @@ class CallFrameInfo::Reporter { // there is not a CIE. virtual void BadCIEId(uint64 offset, uint64 cie_offset); + // The FDE at OFFSET refers to a CIE with an address size we don't know how + // to handle. + virtual void UnexpectedAddressSize(uint64 offset, uint8_t address_size); + + // The FDE at OFFSET refers to a CIE with an segment descriptor size we + // don't know how to handle. + virtual void UnexpectedSegmentSize(uint64 offset, uint8_t segment_size); + // The FDE at OFFSET refers to a CIE with version number VERSION, // which we don't recognize. We cannot parse DWARF CFI if it uses // a version number we don't recognize. |