diff options
| author | erikchen@chromium.org <erikchen@chromium.org> | 2015-01-27 01:20:59 +0000 |
|---|---|---|
| committer | erikchen@chromium.org <erikchen@chromium.org> | 2015-01-27 01:20:59 +0000 |
| commit | 7bebb27fb44920f189310985d96ed7801f59afbb (patch) | |
| tree | 4488552decfc8604e6d4609ba5d56c81baa1e863 /src/common/dwarf_cu_to_module.h | |
| parent | Fix a source of memory corruption. (diff) | |
| download | breakpad-7bebb27fb44920f189310985d96ed7801f59afbb.tar.xz | |
Fix some fragile code that is likely to cause future memory corruption
problems.
- The ordering of keys in stl containers cannot change. Make the relevant
members const to guarantee this assumption.
- Add handling and logging for demangle errors.
- Fix a potential double-delete bug if a function passed to AddFunction() is
already present.
BUG=chromium:449214
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/10704002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1415 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/common/dwarf_cu_to_module.h')
| -rw-r--r-- | src/common/dwarf_cu_to_module.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/common/dwarf_cu_to_module.h b/src/common/dwarf_cu_to_module.h index ab95485f..fd9c380d 100644 --- a/src/common/dwarf_cu_to_module.h +++ b/src/common/dwarf_cu_to_module.h @@ -199,6 +199,9 @@ class DwarfCUToModule: public dwarf2reader::RootDIEHandler { // link. virtual void UnnamedFunction(uint64 offset); + // __cxa_demangle() failed to demangle INPUT. + virtual void DemangleError(const string &input, int error); + // The DW_FORM_ref_addr at OFFSET to TARGET was not handled because // FilePrivate did not retain the inter-CU specification data. virtual void UnhandledInterCUReference(uint64 offset, uint64 target); |