diff options
| author | Ted Mielczarek <ted@mielczarek.org> | 2016-02-12 15:50:16 -0500 |
|---|---|---|
| committer | Ted Mielczarek <ted@mielczarek.org> | 2016-02-12 15:50:16 -0500 |
| commit | e132514d80cb18e65bb63d9c04bfa7965d705dc0 (patch) | |
| tree | a117019cfb4cbb0ae51b9e35864471f364af9865 /src/common/mac/byteswap.h | |
| parent | Fix for linux make check build failure (diff) | |
| download | breakpad-e132514d80cb18e65bb63d9c04bfa7965d705dc0.tar.xz | |
Ensure Linux minidump writer flushes minidump header early.
If the Linux minidump writer crashes while writing a dump, the dump
might contain some useful information, but the header will be empty
because TypedMDRVA's destructor flushes the data, and the header var
doesn't go out of scope until the end of the `Dump` method. This
fixes that problem by putting the header in a shorter block scope.
We've seen this problem in some Android dumps in the wild, like:
https://crash-stats.mozilla.com/report/index/cef5b777-02d1-43c2-bf40-133ab2160209
R=thestig@chromium.org
BUG=https://bugzilla.mozilla.org/show_bug.cgi?id=1247978
Review URL: https://codereview.chromium.org/1696573003 .
Diffstat (limited to 'src/common/mac/byteswap.h')
0 files changed, 0 insertions, 0 deletions