diff options
| author | qsr@chromium.org <qsr@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2011-10-20 15:39:57 +0000 |
|---|---|---|
| committer | qsr@chromium.org <qsr@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2011-10-20 15:39:57 +0000 |
| commit | 70698339f62e96a2729d87970755a9546df2aed1 (patch) | |
| tree | 1bb9fba2052e14299f94663f23ee7769211dbf62 /src/common/mac | |
| parent | Allow to retrieve id of a module from memory instead of going to disk for iOS. (diff) | |
| download | breakpad-70698339f62e96a2729d87970755a9546df2aed1.tar.xz | |
Correct incorrect bounds checking.
Review URL: http://breakpad.appspot.com/319002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@874 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/common/mac')
| -rw-r--r-- | src/common/mac/macho_walker.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/common/mac/macho_walker.cc b/src/common/mac/macho_walker.cc index 00fde03e..26535bc2 100644 --- a/src/common/mac/macho_walker.cc +++ b/src/common/mac/macho_walker.cc @@ -107,11 +107,11 @@ bool MachoWalker::ReadBytes(void *buffer, size_t size, off_t offset) { if (memory_) { bool result = true; if (offset + size > memory_size_) { + if (offset >= memory_size_) + return false; size = memory_size_ - offset; result = false; } - if (size < 0) - return false; memcpy(buffer, static_cast<char *>(memory_) + offset, size); return result; } else { |