diff options
| author | jimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2011-03-11 22:16:12 +0000 |
|---|---|---|
| committer | jimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2011-03-11 22:16:12 +0000 |
| commit | fd18beeb5c817aa3ecdb21caceee8e6ce08c6ab3 (patch) | |
| tree | 5997c04fe096f9b15bbe388af5c7fdd2c466cdc9 /src/common/module.h | |
| parent | Put PUBLIC lines in Mac symbol files. (diff) | |
| download | breakpad-fd18beeb5c817aa3ecdb21caceee8e6ce08c6ab3.tar.xz | |
Google Breakpad Issue 417: Handle DWARF that omits function names.
This patch makes sure dump_syms behaves properly when presented with
malformed DWARF data that provides no name for a function. We print a
warning message to stderr, and subsitute "<name omitted>" for the empty
string, so that the "FUNC" record written to the symbol file for the
function is still well-formed. (We may have line number data covering the
function, so it would be a shame to omit the function altogether.)
Unit tests included.
a=jimblandy, r=ted.mielczarek
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@779 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/common/module.h')
| -rw-r--r-- | src/common/module.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/common/module.h b/src/common/module.h index 83e8403c..8e6a05e2 100644 --- a/src/common/module.h +++ b/src/common/module.h @@ -189,7 +189,7 @@ class Module { // Write is used. void SetLoadAddress(Address load_address); - // Add FUNCTION to the module. + // Add FUNCTION to the module. FUNCTION's name must not be empty. // This module owns all Function objects added with this function: // destroying the module destroys them as well. void AddFunction(Function *function); |