aboutsummaryrefslogtreecommitdiff
path: root/src/common
diff options
context:
space:
mode:
authorPeter Collingbourne <pcc@google.com>2017-11-03 18:26:17 -0700
committerMark Mentovai <mark@chromium.org>2017-11-07 14:56:36 +0000
commit3bbf3fb0db6d751405b6fc30daba478445089e4d (patch)
tree8972683433e335bd874cc754d8889d0ff6b6c12a /src/common
parentCreate LongStringDictionary and replace SimpleStringDictionary on iOS (diff)
downloadbreakpad-3bbf3fb0db6d751405b6fc30daba478445089e4d.tar.xz
dump_symbols: Stop rejecting files with Android packed relocation sections.
The lld linker has native support for creating packed relocation sections, and as a result we can expect files with these sections to have symbols. Bug: chromium:742655 Change-Id: I48a50bff041146f51b3a8b730d7a778f832787f6 Reviewed-on: https://chromium-review.googlesource.com/754239 Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
Diffstat (limited to 'src/common')
-rw-r--r--src/common/linux/dump_symbols.cc31
1 files changed, 0 insertions, 31 deletions
diff --git a/src/common/linux/dump_symbols.cc b/src/common/linux/dump_symbols.cc
index 4e9afd2e..e7a74ccb 100644
--- a/src/common/linux/dump_symbols.cc
+++ b/src/common/linux/dump_symbols.cc
@@ -102,15 +102,6 @@ using google_breakpad::wasteful_vector;
#define EM_AARCH64 183
#endif
-// Define SHT_ANDROID_REL and SHT_ANDROID_RELA if not defined by the host.
-// Sections with this type contain Android packed relocations.
-#ifndef SHT_ANDROID_REL
-#define SHT_ANDROID_REL (SHT_LOOS + 1)
-#endif
-#ifndef SHT_ANDROID_RELA
-#define SHT_ANDROID_RELA (SHT_LOOS + 2)
-#endif
-
//
// FDWrapper
//
@@ -627,28 +618,6 @@ bool LoadSymbols(const string& obj_file,
bool found_debug_info_section = false;
bool found_usable_info = false;
- // Reject files that contain Android packed relocations. The pre-packed
- // version of the file should be symbolized; the packed version is only
- // intended for use on the target system.
- if (FindElfSectionByName<ElfClass>(".rel.dyn", SHT_ANDROID_REL,
- sections, names,
- names_end, elf_header->e_shnum)) {
- fprintf(stderr, "%s: file contains a \".rel.dyn\" section "
- "with type SHT_ANDROID_REL\n", obj_file.c_str());
- fprintf(stderr, "Files containing Android packed relocations "
- "may not be symbolized.\n");
- return false;
- }
- if (FindElfSectionByName<ElfClass>(".rela.dyn", SHT_ANDROID_RELA,
- sections, names,
- names_end, elf_header->e_shnum)) {
- fprintf(stderr, "%s: file contains a \".rela.dyn\" section "
- "with type SHT_ANDROID_RELA\n", obj_file.c_str());
- fprintf(stderr, "Files containing Android packed relocations "
- "may not be symbolized.\n");
- return false;
- }
-
if (options.symbol_data != ONLY_CFI) {
#ifndef NO_STABS_SUPPORT
// Look for STABS debugging information, and load it if present.